The Wayback Machine - https://web.archive.org/web/20210124145952/https://github.com/CorentinJ/Real-Time-Voice-Cloning/issues/522
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume Bar #522

Open
ranshaa05 opened this issue Sep 5, 2020 · 6 comments
Open

Add volume Bar #522

ranshaa05 opened this issue Sep 5, 2020 · 6 comments

Comments

@ranshaa05
Copy link

@ranshaa05 ranshaa05 commented Sep 5, 2020

some recordings have low volume so the output can be sometimes really quiet. how about we add a volume bar so we can make the output louder/quieter?

@blue-fish
Copy link
Collaborator

@blue-fish blue-fish commented Sep 5, 2020

@ranshaa05 Interesting suggestion. Have you tried selecting the "enhance vocoder output" button on the toolbox UI? We added that to trim silences, but it also normalizes the volume of the generated wav.

@ranshaa05
Copy link
Author

@ranshaa05 ranshaa05 commented Sep 5, 2020

@ranshaa05 Interesting suggestion. Have you tried selecting the "enhance vocoder output" button on the toolbox UI? We added that to trim silences, but it also normalizes the volume of the generated wav.

It doesn't work for me at the moment (looks like some cudnn shannanigans) but i do remember it making the output a bit louder, but it certainly wasnt perfect. Even the "normalize" option in audacity doesnt work 100% of the time. That's why im suggesting a simple volume bar to have a bit more control over the actual volume.

@blue-fish
Copy link
Collaborator

@blue-fish blue-fish commented Sep 6, 2020

The toolbox is not intended to be a full-featured text-to-speech solution, but I can understand the desire for this capability since the output volume is not consistent for different speakers.

Are you able to develop this feature and submit a pull request? Or are you asking for someone else to take on this task?

@ranshaa05
Copy link
Author

@ranshaa05 ranshaa05 commented Sep 6, 2020

The toolbox is not intended to be a full-featured text-to-speech solution, but I can understand the desire for this capability since the output volume is not consistent for different speakers.

Are you able to develop this feature and submit a pull request? Or are you asking for someone else to take on this task?

Unfortunately i am not skilled enough in python to develop this feature, so yeah, im asking for somebody else to do it.

@blue-fish
Copy link
Collaborator

@blue-fish blue-fish commented Sep 11, 2020

@ranshaa05 I'll gladly work this when the pytorch PR, bugs and dependency issues are complete. Or possibly earlier if I have a free moment.

Since it could be a while I'll flag this as an issue for others to help out.

@ranshaa05
Copy link
Author

@ranshaa05 ranshaa05 commented Sep 14, 2020

@ranshaa05 I'll gladly work this when the pytorch PR, bugs and dependency issues are complete. Or possibly earlier if I have a free moment.

Since it could be a while I'll flag this as an issue for others to help out.

thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants