The Wayback Machine - https://web.archive.org/web/20200925141242/https://github.com/streamnative/kop/pull/158
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kafka-python 1.3.3 test case #158

Open
wants to merge 3 commits into
base: master
from

Conversation

@hangc0276
Copy link
Contributor

hangc0276 commented May 29, 2020

Add kafka-python 1.3.3 test case

@hangc0276 hangc0276 requested review from jiazhai and sijie as code owners May 29, 2020
@sijie
sijie approved these changes May 29, 2020
@hangc0276 hangc0276 force-pushed the hangc0276:python_docker_testcase branch from 3344514 to f11ad8f Jun 1, 2020
@sijie
Copy link
Member

sijie commented Jun 1, 2020

@hangc0276 Can you move the changes under integrations/python2-kafka-python/* a separate pull request? So we can get the dockerfile change merged and a new image can be pushed to docker hub. Then your integration test can use it.

@hangc0276
Copy link
Contributor Author

hangc0276 commented Jun 1, 2020

@hangc0276 Can you move the changes under integrations/python2-kafka-python/* a separate pull request? So we can get the docerfile change merged and a new image can be pushed to docker hub. Then your integration test can use it.

@sijie Thanks for your reply. I have changed kafka-python test case dockerfile to integrations/python2-kafka-python/ and all the versions of kafka-python will use the same docker image to run test cases.

@sijie
Copy link
Member

sijie commented Jun 2, 2020

@hangc0276 correct. the issue failed with the following error Caused by: com.github.dockerjava.api.exception.NotFoundException: {"message":"pull access denied for streamnative/kop-test-python2-kafka-python, repository does not exist or may require 'docker login': denied: requested access to the resource is denied"}

It means we didn't have the image yet. My suggestion is to create a separate pull request that only includes the docker change. So we can merge that pull request and get the docker image published to streamnative/kop-test-python2-kafka-python. So the integration tests in this pull request can use that image.

@hangc0276
Copy link
Contributor Author

hangc0276 commented Jun 2, 2020

@hangc0276 correct. the issue failed with the following error Caused by: com.github.dockerjava.api.exception.NotFoundException: {"message":"pull access denied for streamnative/kop-test-python2-kafka-python, repository does not exist or may require 'docker login': denied: requested access to the resource is denied"}

It means we didn't have the image yet. My suggestion is to create a separate pull request that only includes the docker change. So we can merge that pull request and get the docker image published to streamnative/kop-test-python2-kafka-python. So the integration tests in this pull request can use that image.

@sijie OK, i will use a separate PR to build the docker image.

@sijie sijie added this to the 0.3.0 milestone Jun 10, 2020
@sijie sijie added the area/test label Jun 10, 2020
@sijie
Copy link
Member

sijie commented Jul 1, 2020

@hangc0276 any updates on this pull request?

@hangc0276
Copy link
Contributor Author

hangc0276 commented Jul 1, 2020

@hangc0276 any updates on this pull request?

Yes, I will update the docker image soon.

@hangc0276 hangc0276 force-pushed the hangc0276:python_docker_testcase branch from 40441a5 to 852b1c2 Jul 11, 2020
@hangc0276
Copy link
Contributor Author

hangc0276 commented Jul 11, 2020

@sijie I have update the kafka-python and pykafka integration test framework. Some versions are not supported, and I have exclude them in the integration test.

hangc0276 added 2 commits Jul 11, 2020
@jiazhai jiazhai closed this Aug 18, 2020
@jiazhai jiazhai reopened this Aug 18, 2020
@jiazhai
Copy link
Contributor

jiazhai commented Aug 19, 2020

synced with @hangc0276 , Test failure caused by the docker image, maybe we should fix the image first:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.