Adding support for semantic color for icons #1182
Merged
+77
−16
Conversation
|
Build successful! |
LFDanLu
changed the title
|
Build successful! |
|
Build successful! |
| @@ -10,6 +10,8 @@ | |||
| * governing permissions and limitations under the License. | |||
| */ | |||
|
|
|||
| // This file is generated by lib/varsToTypeScript.js! DO NOT EDIT. | |||
snowystinger
Oct 20, 2020
Collaborator
?
?
LFDanLu
Oct 20, 2020
Author
Collaborator
generated by running varsToTypeScript, not entirely sure if we wanna keep or not.
generated by running varsToTypeScript, not entirely sure if we wanna keep or not.
snowystinger
Oct 20, 2020
Collaborator
but why wasn't it there previously?
but why wasn't it there previously?
LFDanLu
Oct 20, 2020
Author
Collaborator
dunno, removed in this pull: #206. Not sure the reason for its removal, seems innocuous to me (helps others understand where the file came from)
dunno, removed in this pull: #206. Not sure the reason for its removal, seems innocuous to me (helps others understand where the file came from)
snowystinger
Oct 20, 2020
Collaborator
yeah, i'm definitely in favor of leaving it in if it is truly a generated file
yeah, i'm definitely in favor of leaving it in if it is truly a generated file
| ```tsx example | ||
| import Alert from '@spectrum-icons/workflow/Alert'; | ||
| <Alert /> |
snowystinger
Oct 21, 2020
Collaborator
Should we wrap these in a Flex with a gap so they aren't quite that close together?
Also we should put an aria-label on them, otherwise we'll likely get some warnings
Should we wrap these in a Flex with a gap so they aren't quite that close together?
Also we should put an aria-label on them, otherwise we'll likely get some warnings
| @@ -95,6 +99,8 @@ export type DimensionValue = | |||
| | number; | |||
|
|
|||
| export type ColorValue = | |||
| | 'status' | |||
| | 'version' | |||
devongovett
Oct 22, 2020
Member
These seem like parsing issues. I don't think they are real variable names?
These seem like parsing issues. I don't think they are real variable names?
LFDanLu
Oct 23, 2020
Author
Collaborator
ah you are right, I'll update the regex in the script
ah you are right, I'll update the regex in the script
|
Build successful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Closes #1159