The Wayback Machine - https://web.archive.org/web/20210118004722/https://github.com/danger/danger-js/pull/1098
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gitlab add MR approvals related information #1098

Open

Conversation

@kelvin-lemon
Copy link

@kelvin-lemon kelvin-lemon commented Jan 8, 2021

#1069
The number of approvals cannot be obtained correctly through danger.gitlab.mr.approvals_before_merge.
According to the GitLab API instructions, newer versions need to be picked up through the Approvals interface.

@danger-public
Copy link

@danger-public danger-public commented Jan 8, 2021

Warnings
⚠️

Please add a changelog entry for your changes. You can find it in CHANGELOG.md

Please add your change and name to the master section.

Generated by 🚫 dangerJS against ef4a2ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.