The Wayback Machine - https://web.archive.org/web/20210108194455/https://github.com/Bitmessage/PyBitmessage/pull/1707
Skip to content

/ PyBitmessage

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP OpenSSL improve memory handling #1707

Draft
wants to merge 1 commit into
base: v0.6
from
Draft

WIP OpenSSL improve memory handling #1707

wants to merge 1 commit into from
+100 −74

Conversation

@PeterSurda
Copy link
Member

@PeterSurda PeterSurda commented Jan 3, 2021 •
edited

  • replace void * with BIGNUM * where applicable
  • addresses #1622
  • replace 0 with None when using a NULL pointer as parameter
  • EC_POINT struct is now defined but isn't used yet
  • blind signature tests now pass on 64bit wine
  • still crashes on W10 when decoding messages for your address or when generating an address
@PeterSurda PeterSurda added the bug label Jan 3, 2021
@PeterSurda PeterSurda added this to To do in Code quality via automation Jan 3, 2021
@PeterSurda PeterSurda added this to To do in Bugs via automation Jan 3, 2021
@PeterSurda PeterSurda added this to the v0.6.4 milestone Jan 3, 2021
@PeterSurda PeterSurda self-assigned this Jan 3, 2021
@PeterSurda PeterSurda force-pushed the PeterSurda:bignum_pointers_1 branch 2 times, most recently from 025f7c5 to cdc15d6 Jan 4, 2021
@PeterSurda
OpenSSL improve memory handling
Verified
This commit was signed with a verified signature.
PeterSurda Peter Šurda
GPG key ID: 0C5F50C0B5F37D87 Learn about signing commits
Loading status checks…
18221ed 
- replace void * with BIGNUM * where applicable
- fixes #1622
- replace 0 with None when using a NULL pointer as parameter
- maybe needs more work in how the data is accessed
- EC_POINT struct is now defined but isn't used yet
@PeterSurda PeterSurda force-pushed the PeterSurda:bignum_pointers_1 branch from cdc15d6 to 18221ed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
1 participant
@PeterSurda
You can’t perform that action at this time.