The Wayback Machine - https://web.archive.org/web/20210108194439/https://github.com/Bitmessage/PyBitmessage/pull/1671
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the app closing issue on the press of quit button #1671

Open
wants to merge 6 commits into
base: v0.6
from

Conversation

@navjotcis
Copy link
Contributor

@navjotcis navjotcis commented Sep 18, 2020

Here when user try to quit the app then the app does not close it takes time longer than expected so I have fixed it for two cases

  1. when the user open the app and closes it before the connection popup shows then the app does not close. It runs in a loop for n no. of times which takes sometimes 2-3 minutes or longer then it so I have added the condition with it for checking if the user presses quit then it will not go into the loop and close the app.
  2. This case appears sometimes so here also app not close when the user tries to quit because there is condition pendingDownload() > 0 so app-only close when pendingDownload() returns 0 or less so the value of pendingDownload() method is not fixed sometimes it gives a large no. which run in the loop N no. of times so also it does not close the app until loop executes N no. of times so I have also added the condition here when the user press the quit then it does not go into the loop and close the app.
@navjotcis navjotcis force-pushed the navjotcis:bug-fixes4 branch 3 times, most recently from 5dba4ae to c5e440b Oct 8, 2020
@PeterSurda
Copy link
Member

@PeterSurda PeterSurda commented Oct 13, 2020

This isn't working correctly. I know I made recommendations, but at best they were incomplete. Find a way to fix this properly.

@navjotcis navjotcis force-pushed the navjotcis:bug-fixes4 branch from c5e440b to 6d5395c Oct 17, 2020
@navjotcis
Copy link
Contributor Author

@navjotcis navjotcis commented Oct 17, 2020

I have tested all the scenarios and then I have made the table for all the cases and all are passed
image

@navjotcis navjotcis force-pushed the navjotcis:bug-fixes4 branch from 7a4af58 to 48b0531 Oct 27, 2020
@navjotcis
Copy link
Contributor Author

@navjotcis navjotcis commented Oct 27, 2020

I have changed the UI of the app closing popup and also when the user click on the Quit button I am showing a progress bar and on the press of don't quit progress bar will disappear. Fixes #1298

@navjotcis navjotcis force-pushed the navjotcis:bug-fixes4 branch 3 times, most recently from c809b73 to 5173d28 Oct 28, 2020
@navjotcis navjotcis force-pushed the navjotcis:bug-fixes4 branch 2 times, most recently from ea5d50d to 649e4ba Nov 4, 2020
@navjotcis navjotcis force-pushed the navjotcis:bug-fixes4 branch 3 times, most recently from 0150442 to 29c2549 Nov 21, 2020
@navjotcis navjotcis force-pushed the navjotcis:bug-fixes4 branch 2 times, most recently from ca694d6 to cb6a0d2 Dec 21, 2020
@navjotcis navjotcis force-pushed the navjotcis:bug-fixes4 branch from 8647974 to a5b9c37 Dec 31, 2020
navjotcis added 6 commits Sep 18, 2020
@navjotcis navjotcis force-pushed the navjotcis:bug-fixes4 branch from a5b9c37 to 6d8b45a Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.