(WIP) Bug rad reverse sorting #1021
Conversation
|
I used this to test locally
|
|
@alterx yay for helping fix bugs! Very much appreciated. The fact Martti can run this with Iris and no problems is a big win / indication it is correct. Sorry I've been bogged down. When we chatted the other day it seems like mocha in the browser also had the same failure as NodeJS, so we should review that before pulling (bleeh ugh I hate saying this). I 100% predict it is bug in my code tho, not yours. My mental state hasn't been very good tho to see why (tho I'm excited jibbery that you've done this!), so is it OK if I don't pull quite yet? I feel sad I've been the bottleneck :( |
|
@amark no problem, I need to find some time to figure out why this is not working inside the test. I definitely think we should wait until there's at least one functional unit test, this way it won't break again in the future. One thing that's worth noting is that the previous test was being explicitly skipped, maybe an indication that this issue with testing reverse happened before? |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

This PR aims to fix the issues with
reversewhen using RAD's lexical querying. I've tested the fix in the browser and it works, but, for some reason, the test is not passing (reverse is not working when running mocha)