JamesNK
Follow
Pinned
1,330 contributions in the last year
Activity overview
Contribution activity
December 2020
Created 34 commits in 6 repositories
Created 3 repositories
- JamesNK/SerializationBenchmark C#
- JamesNK/omnisharp-vscode TypeScript
- JamesNK/schemastore JavaScript
Created a pull request in dotnet/AspNetCore.Docs that received 6 comments
Opened 38 other pull requests in 10 repositories
dotnet/aspnetcore
3
open
14
merged
1
closed
- Add OWIN docs
- Fix MVC null reference build error
- HTTP/3: Add CompleteAsync tests and fix various bugs
- Enable nullable on HealthChecks.EntityFrameworkCore
- Enable nullable on Diagnostics.EntityFrameworkCore
- Allow nullable with IFeatureCollection generic Get/Set
- Enable nullable on Kestrel generated code
- Enable nullable on IIS
- Fix IServerVariableFeature nullable
- HTTP/3: Update alt-svc value to h3-29 and add unit test
- HTTP/3: Add trailers and reset features
- Enable nullable on Diagnostics and Rewrite middleware
- Enable nullable on FileProviders and Config.KeyPerFile
- Enable nullable on DataProtection
- Add test and friendly error when attempting to load public key
- [release/5.0] Update gRPC packages to 2.34.0 to fix MacOS tooling issue
- Enable nullable on server transports
- Enable nullable in TestHost and Hosting.WindowsServices
dotnet/AspNetCore.Docs
4
merged
1
open
grpc/grpc-dotnet
4
merged
protocolbuffers/protobuf
3
open
JamesNK/Newtonsoft.Json
2
open
dotnet/AspNetApiDocs
2
merged
geeknoid/SerializationBenchmark
1
closed
OmniSharp/omnisharp-vscode
1
merged
SchemaStore/schemastore
1
open
dotnet/runtime
1
merged
Reviewed 33 pull requests in 6 repositories
dotnet/aspnetcore 21 pull requests
- Add OWIN docs
- Use Environment.ProcessId instead of Process.GetCurrentProcess().Id
- Add nullable annotations to Mvc.Core/Infrastructure
- Add more doc comments
- Add docs for Microsoft.AspNetCore.Http
- Add nullable annotations to Mvc.Core/Routing
- Enable nullable on Kestrel generated code
- Fix graceful shutdown of connection close in HTTP/3
- HTTP/3: Add trailers and reset features
- Use range syntax
- Enable nullable on Diagnostics and Rewrite middleware
- Fix typo in XML comment
- Enable nullable on DataProtection
- Make the sample work
- Change nint -> IntPtr
- Add XML doc comments for Microsoft.Net.Http.Headers
- Avoid allocations from LINQ.ToArray()
- Enable nullable on server transports
- Enable nullable in TestHost and Hosting.WindowsServices
- Clean up some http.sys code
- Support W3C Baggage header
grpc/grpc-dotnet 5 pull requests
dotnet/AspNetApiDocs 4 pull requests
protocolbuffers/protobuf 1 pull request
JamesNK/Newtonsoft.Json 1 pull request
microsoft/reverse-proxy 1 pull request
Created an issue in dotnet/aspnetcore that received 3 comments
HTTP/3: Connection not upgraded to HTTP/3 with HttpClient
Kestrel currently sends back alt-srv value of h3-25.
aspnetcore/src/Servers/Kestrel/Core/src/Internal/Http/HttpProtocol.cs Lines 1187 to 1198 in
3
comments
Opened 8 other issues in 5 repositories
dotnet/aspnetcore
3
open
dotnet/runtime
2
open
dotnet/roslyn-analyzers
1
open
OmniSharp/omnisharp-vscode
1
closed
dotnet/core
1
open
2
contributions
in private repositories
Dec 11