The Wayback Machine - https://web.archive.org/web/20201201155545/https://github.com/line/armeria/issues/2149
Skip to content

/ armeria

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the cardinality of request metrics #2149

Open
trustin opened this issue Oct 3, 2019 · 7 comments
Open

Limit the cardinality of request metrics #2149

trustin opened this issue Oct 3, 2019 · 7 comments
Labels
good first issue new feature

Comments

@trustin
Copy link
Collaborator

@trustin trustin commented Oct 3, 2019

I heard that RestTemplate logs a warning about large cardinality of meter tags and refuses to record the metrics for the tag combinations generated after then. We could also implement something similar.
@trustin
Copy link
Collaborator Author

@trustin trustin commented Oct 3, 2019 •
edited

Related commit: spring-projects/spring-boot@1a9c268
Related issue: spring-projects/spring-boot#11338
Related MeterFilter implementation in Micrometer: https://github.com/micrometer-metrics/micrometer/blob/HEAD@%7B2019-10-03T06:14:12Z%7D/micrometer-core/src/main/java/io/micrometer/core/instrument/config/MeterFilter.java#L207-L231
@trustin
Copy link
Collaborator Author

@trustin trustin commented Oct 3, 2019 •
edited

In Armeria, MetricCollecting{Client,Service} collects the request metrics. We could modify them to count the cardinality and enforce the limitation.

We need to:

  • Allow a user specify max cardinality when creating MetricCollecting{Client,Service}.
  • Modify MetricCollecting{Client,Service} to respect the max cardinality and warn when the cardinality is too large.
  • Add the configuration property for the max cardinality to the Spring Boot integration.
@SooJungDev
Copy link
Contributor

@SooJungDev SooJungDev commented Oct 11, 2019

I'll work on it
@trustin
Copy link
Collaborator Author

@trustin trustin commented Oct 11, 2019

It's all yours, @SooJungDev!
@heowc
Copy link
Contributor

@heowc heowc commented Jan 10, 2020

@SooJungDev @trustin Gentle ping 😉

I'm interested in this. Can I try?
Or can you recommend another issue?
@SooJungDev
Copy link
Contributor

@SooJungDev SooJungDev commented Jan 10, 2020 •
edited

yes, you can try!!@heowc thank you😉
@heowc
Copy link
Contributor

@heowc heowc commented Jan 14, 2020

@trustin

I've been analyzing the code for a few days, and I have some questions.

We could also implement something similar. (comment)

Does it mean to use Meterfilter? Or does it mean a similar implementation? It seems strange to integrate with spring boot if you mean to implement similarly.

Allow a user to specify max cardinality when creating MetricCollecting{Client,Service}. (comment)

Why should the user set max cardinality in MetricCollecting {Client, Service}? Isn't it a good idea to set it in the registry?

If I'm misunderstanding, please point me in the right path. Thank you. 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue new feature
3 participants
@trustin @heowc @SooJungDev
You can’t perform that action at this time.