The Wayback Machine - https://web.archive.org/web/20201126012946/https://github.com/TheAlgorithms/Python/pull/3849
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check initial grid availability for backtracking/sudoku.py #3849

Open
wants to merge 4 commits into
base: master
from

Conversation

@RonDingDing
Copy link

@RonDingDing RonDingDing commented Oct 31, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
initial_grid = [
    [3, 0, 6, 5, 0, 8, 4, 0, 0],
    [5, 2, 0, 0, 0, 0, 0, 0, 0],
    [0, 8, 7, 0, 0, 0, 0, 3, 1],
    [0, 0, 3, 0, 1, 0, 0, 8, 0],
    [9, 0, 0, 8, 6, 3, 0, 0, 5],
    [0, 5, 0, 0, 9, 0, 6, 0, 0],
    [1, 3, 0, 0, 0, 0, 2, 5, 0],
    [0, 0, 0, 0, 0, 0, 0, 7, 4],
    [0, 0, 5, 2, 0, 6, 3, 0, 0],
]

In the previous code, if you change 9 at the fifth line to 5, the program will give you a solution. But the output does not conform to the definition of sudoku. It means the program is not checking the input at all. So I add some validation of the input, specifying the grid to be 9*9 2D-list of 0-9.

@RonDingDing RonDingDing reopened this Oct 31, 2020
@RonDingDing RonDingDing changed the title @RonDingDing Check initial grid availability for backtracking/sudoku.py Check initial grid availability for backtracking/sudoku.py Oct 31, 2020
@RonDingDing RonDingDing force-pushed the RonDingDing:master branch from adc117c to d58d0a9 Oct 31, 2020
backtracking/sudoku.py Outdated Show resolved Hide resolved
RonDingDing added 2 commits Nov 10, 2020
@RonDingDing
Copy link
Author

@RonDingDing RonDingDing commented Nov 12, 2020

???

@RonDingDing RonDingDing reopened this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.