The Wayback Machine - https://web.archive.org/web/20201208144843/https://github.com/google/gvisor/issues/3053
Skip to content

/ gvisor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runsc install need support podman #3053

Open
unknowndev233 opened this issue Jun 23, 2020 · 5 comments
Open

runsc install need support podman #3053

unknowndev233 opened this issue Jun 23, 2020 · 5 comments
Labels
good first issue type: enhancement

Comments

@unknowndev233
Copy link

@unknowndev233 unknowndev233 commented Jun 23, 2020

Description

runsc install is able to edit /etc/docker/daemon.json to enable Docker to replace runc with runsc.
Would be great if podman supports this feature.

Is this feature related to a specific bug?

No. By the way, does gVisor depend on Docker just for the reason that Docker uses runsc as its runtime?

Do you have a specific solution in mind?

To replace the runtime of podman, just add runtime = "/path/to/runsc" to /etc/containers/libpod.conf
@amscanne
Copy link
Collaborator

@amscanne amscanne commented Jun 23, 2020

No. By the way, does gVisor depend on Docker just for the reason that Docker uses runsc as its runtime?

Nope, this is just a convenience because Docker is a common path. I think this feature sounds good.
@unknowndev233
Copy link
Author

@unknowndev233 unknowndev233 commented Jun 26, 2020 •
edited

Nope, this is just a convenience because Docker is a common path. I think this feature sounds good.

Should docker not be written in the dependency list?
@amscanne
Copy link
Collaborator

@amscanne amscanne commented Jun 26, 2020

I'm not sure I understand the question: docker is not a dependency. You can use runsc by itself via "runsc do" or via the manual podman configuration. The install happens only if an existing /etc/docker/daemon.json is present: https://github.com/google/gvisor/blob/master/runsc/debian/postinst.sh#L21
@unknowndev233
Copy link
Author

@unknowndev233 unknowndev233 commented Jul 11, 2020

I'm not sure I understand the question: docker is not a dependency. You can use runsc by itself via "runsc do" or via the manual podman configuration. The install happens only if an existing /etc/docker/daemon.json is present: https://github.com/google/gvisor/blob/master/runsc/debian/postinst.sh#L21

Why is the "docker" in the requirement list?
image
@ianlewis
Copy link
Contributor

@ianlewis ianlewis commented Jul 13, 2020

Why is the "docker" in the requirement list?

Those are the requirements for installing from source. There is a note just above the requirements:

"For the purposes of these instructions, bazel and other build dependencies are wrapped in a build container."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue type: enhancement
3 participants
@ianlewis @amscanne @unknowndev233
You can’t perform that action at this time.