Nuget package + release notes #10024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love it. Quick note on markdown: if you don't want to have to duplicate attribution for folks, you can use reference-style-links to only have to define the link's address once, and reuse it in all other locations. |
cartermp
approved these changes
Aug 27, 2020
| @@ -17,7 +17,8 @@ | |||
| <PackageId>FSharp.Core</PackageId> | |||
| <NuspecFile>FSharp.Core.nuspec</NuspecFile> | |||
| <IsPackable>true</IsPackable> | |||
| <PackageDescription>FSharp.Core redistributables from Visual F# Tools version $(FSPackageMajorVersion) For F# $(FSCoreMajorVersion). Contains code from the F# Software Foundation.</PackageDescription> | |||
| <PackageDescription>FSharp.Core redistributables from Visual F# Tools version $(FSCorePackageVersion) For F# $(FSLanguageVersion). Contains code from the F# Software Foundation.</PackageDescription> | |||
There was a problem hiding this comment.
Suggested change
| <PackageDescription>FSharp.Core redistributables from Visual F# Tools version $(FSCorePackageVersion) For F# $(FSLanguageVersion). Contains code from the F# Software Foundation.</PackageDescription> | |
| <PackageDescription>FSharp.Core redistributables from F# Tools version $(FSCorePackageVersion) For F# $(FSLanguageVersion). Contains code from the F# Software Foundation.</PackageDescription> |
Let's finally drop the "Visual" from here :)
There was a problem hiding this comment.
The fcs release notes are already in, they are at the bottom of the release-notes file.
Yes I can yeet the Visual from Visual FSharp.
There was a problem hiding this comment.
Yee
brettfo
approved these changes
Aug 27, 2020
eng/Versions.props
Outdated
| @@ -11,29 +11,46 @@ | |||
| </PropertyGroup> | |||
| <!-- Version number computation --> | |||
| <PropertyGroup> | |||
|
|
|||
There was a problem hiding this comment.
Nit: Arcade updates will remove the newlines in this file.
nosami
added a commit
to xamarin/visualfsharp
that referenced
this issue
Feb 23, 2021
* Nuget package + release notes * feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Transfer FCS release notes into release-notes.md.
Add new sections to the release notes:
The release notes will be maintained in the main branch of the dotnet/fsharp repo. The nuget packages wll contain a link to them.
This pr: also generate uri's for release notes element of nuspec file that point to the relevent sections.
FSharp.Core uri looks similar to:
https://github.com/dotnet/fsharp/blob/main/release-notes.md#FSharp-Core-5-0-0
Compiler.Service:
https://github.com/dotnet/fsharp/blob/main/release-notes.md#FSharp-Compilere-Service-37-0-0
The text was updated successfully, but these errors were encountered: