The Wayback Machine - https://web.archive.org/web/20201220223212/https://github.com/paceholder/nodeeditor/issues/257
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build, Linux #257

Closed
duncanam opened this issue Jan 24, 2020 · 7 comments
Closed

Cannot build, Linux #257

duncanam opened this issue Jan 24, 2020 · 7 comments

Comments

@duncanam
Copy link

@duncanam duncanam commented Jan 24, 2020

I have all the dependencies, and make it to the step where I perform make -j && make install. I get hit with:

error.log

Any ideas?

@paceholder
Copy link
Owner

@paceholder paceholder commented Jan 24, 2020

Hi Duncan,

it looks like the developers have added the implementation of std::hash in 5.13 and we do not need anymore the content of include/nodes/internal/QStringStdHash.hpp

See commit https://code.qt.io/cgit/qt/qtbase.git/commit/?id=4469e36d7203a55a4e158a50f0e9effc3f2fa3c2

I have Qt 5.13 on my machine as well and strangely can't reproduce your issue.

Temporarily you could comment out the content of QStringStdHash.hpp to proceed with your work. I'll see what could be done.

Thanks

Dmitry

@paceholder
Copy link
Owner

@paceholder paceholder commented Jan 24, 2020

Ok, it seems that the change made it to 5.14

paceholder added a commit that referenced this issue Jan 24, 2020
@duncanam
Copy link
Author

@duncanam duncanam commented Jan 24, 2020

@paceholder Hi there, I believe that is now functioning on my end. It successfully installed when I comment out the content of that file.

Additionally, I'm not sure if I'm going about compiling the examples the wrong way:

  1. navigate to example directory
  2. cmake CMakeLists.txt
  3. make then gives me an error:

[ 12%] Building CXX object CMakeFiles/calculator.dir/Converters.o In file included from /usr/local/include/nodes/NodeDataModel:1, from /home/duncan/github/external/nodeeditor/examples/calculator/DecimalData.hpp:3, from /home/duncan/github/external/nodeeditor/examples/calculator/Converters.hpp:3, from /home/duncan/github/external/nodeeditor/examples/calculator/Converters.cpp:1: /usr/local/include/nodes/internal/NodeDataModel.hpp:4:10: fatal error: QtWidgets/QWidget: No such file or directory 4 | #include <QtWidgets/QWidget> | ^~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [CMakeFiles/calculator.dir/build.make:76: CMakeFiles/calculator.dir/Converters.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/calculator.dir/all] Error 2 make: *** [Makefile:84: all] Error 2

I'm probably missing something as I'm not incredibly familiar with this build process. Perhaps there's something I need to export or I am compiling them incorrectly?

paceholder added a commit that referenced this issue Jan 24, 2020
@paceholder
Copy link
Owner

@paceholder paceholder commented Jan 24, 2020

Typically I do this:

> cd nodeeditor
> mkdir build
> cd build
> cmake ..
> make -j

Afterwards all the examples are located in nodeeditor/build/bin

[paceholder@xps13 build]$ ls bin
calculator  connection_colors  example2  images  styles  test_nodes
@duncanam
Copy link
Author

@duncanam duncanam commented Jan 24, 2020

Ah, yes. They were already compiled. Everything looks good, I'll play around with it further and see what comes of it all! Thanks again.

I don't know if you'd like me to close this issue now since I "solved" it by commenting out that file, but I am happy to.

@paceholder
Copy link
Owner

@paceholder paceholder commented Jan 24, 2020

@duncanam
Copy link
Author

@duncanam duncanam commented Jan 24, 2020

I removed, recloned, and followed the README and it all functioned as expected. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.