Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
feat: add list with open pull requests on user profile pages #554
Conversation
alejandronanez
requested review from
housseindjirdeh,
alejandronanez,
lex111 and
andrewda
|
@radiKal07 Nice job and welcome to become a new contributor! But maybe we need to discuss the design first. Pending the PR list at the end of own profile seems not to be the best idea, especially we may need closed PR list and open/closed issue list in future. #500 doesn't require a PR list for other user's profile, which keeps the same with Github. It expects something like contribution calendar. At last, |
| /> | ||
| )} | ||
| </SectionList> | ||
|
|
chinesedfan
Oct 22, 2017
Member
Usually, we only care about our PRs, but do not for other users'.
Usually, we only care about our PRs, but do not for other users'.
| @@ -157,6 +159,34 @@ export const getUserEvents = user => { | |||
| }; | |||
| }; | |||
|
|
|||
| export const searchUserOpenPullRequests = () => { | |||
chinesedfan
Oct 22, 2017
Member
I suggest to rename as getOpenPullRequest, which is simpler and more similar with other functions.
I suggest to rename as getOpenPullRequest, which is simpler and more similar with other functions.
| @@ -7,3 +7,4 @@ export const GET_AUTH_ORGS = createActionSet('GET_AUTH_ORGS'); | |||
| export const GET_EVENTS = createActionSet('GET_EVENTS'); | |||
| export const CHANGE_LOCALE = createActionSet('CHANGE_LOCALE'); | |||
| export const GET_AUTH_STAR_COUNT = createActionSet('GET_AUTH_STAR_COUNT'); | |||
| export const SEARCH_USER_OPEN_PULL_REQUESTS = createActionSet('SEARCH_USER_OPEN_PULL_REQUESTS'); | |||
chinesedfan
Oct 22, 2017
Member
Similar here. Let's make actions start with GET_.
Similar here. Let's make actions start with GET_.
alejandronanez
Oct 22, 2017
Member
GET_USER_OPEN_PULL_REQUESTS maybe.
GET_USER_OPEN_PULL_REQUESTS maybe.
| @@ -7,6 +7,7 @@ import { | |||
| GET_EVENTS, | |||
| CHANGE_LOCALE, | |||
| GET_AUTH_STAR_COUNT, | |||
| SEARCH_USER_OPEN_PULL_REQUESTS, | |||
| } from './auth.type'; | |||
|
|
|||
| const initialState = { | |||
chinesedfan
Oct 22, 2017
Member
You'd better add an initial value here.
You'd better add an initial value here.
| case SEARCH_USER_OPEN_PULL_REQUESTS.PENDING: | ||
| return { | ||
| ...state, | ||
| isPendingSearchUserOpenPullRequests: true, |
chinesedfan
Oct 22, 2017
Member
This field can be renamed correspondingly.
This field can be renamed correspondingly.
| user: Object, | ||
| orgs: Array, | ||
| searchedUserOpenPullRequests: Array, |
chinesedfan
Oct 22, 2017
Member
searchUserOpenPullRequests and searchedUserOpenPullRequests are really easy to be mixed.
searchUserOpenPullRequests and searchedUserOpenPullRequests are really easy to be mixed.
andrewda
changed the title
| noItemsMessage={translate('repository.main.noOpenPullRequestsMessage', locale)} | ||
| > | ||
| {searchedUserOpenPullRequests.map(item => | ||
| <IssueListItem |
alejandronanez
Oct 22, 2017
Member
Can you please add the key prop for IssueListItem? Thanks!
Can you please add the key prop for IssueListItem? Thanks!
|
| > | ||
| {searchedUserOpenPullRequests.map(item => | ||
| <IssueListItem | ||
| type={'git-pull-request'} |
alejandronanez
Oct 22, 2017
Member
Add key prop in here please.
Add key prop in here please.
Fixed #500
On user profile pages and on own profile page now there can be seen a list with open pull requests.