The Wayback Machine - https://web.archive.org/web/20240805095241/https://github.com/mozilla-mobile/fenix/issues/16519
Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] (regression) missing space between header bar and {remove downloads|delete history} button #16519

Closed
cadeyrn opened this issue Nov 12, 2020 · 5 comments
Closed

[Bug] (regression) missing space between header bar and {remove downloads|delete history} button #16519

cadeyrn opened this issue Nov 12, 2020 · 5 comments
Assignees
@joc-a
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download good first issue Good for newcomers

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Nov 12, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. download something
  2. open the downloads view

or

  1. open the history view

Expected behavior

There is some space above the remove downloads / delete history button.

Actual behavior

There no space. It's a regression that does not exist in Firefox Beta.

Screenshot_20201112-094520

Device information

  • Android device: OnePlus 7T Pro McLaren Edition / Oxygen OS 10.0.12 (Android 10)
  • Fenix version: master branch revision 710d689

┆Issue is synchronized with this Jira Task
@cadeyrn cadeyrn added the 🐞 bug Crashes, Something isn't working, .. label Nov 12, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 12, 2020
@mcarare mcarare added Feature:Download good first issue Good for newcomers and removed needs:triage Issue needs triage labels Nov 13, 2020
@joc-a
Copy link
Contributor

joc-a commented Jan 6, 2021

I would like to work on this!
joc-a added a commit to joc-a/fenix that referenced this issue Jan 7, 2021
@joc-a
For mozilla-mobile#16519: Add space above Delete Downloads and Delete…
7eea454 
… History buttons

add space above Delete Downloads and Delete History buttons
@joc-a
Copy link
Contributor

joc-a commented Jan 7, 2021

#17358
@Mugurell
Copy link
Contributor

Thank you all for chiming in here but I don't think the changes from #17358 are needed anymore.

  • The "Delete downloads" button is not used anymore following Downloads UX updates #16541. I've created Remove dead code around "Delete downloads" #17393 to know for sure if the related code can be removed.
  • Regarding "Delete history" I'd say the proposed changes would make it look better but I don't see any recent change that could regress the UI and didn't find an Abstract or clear specs for how that screen should look.
    Asking UX if we should add a 8dp top margin to the "Delete history" button that would result in the following:
Before After
@Mugurell Mugurell added the needs:UX-feedback Needs UX Feedback label Jan 11, 2021
@topotropic
Copy link

Yes, please – the added 8dp is looking good! Thanks, @Mugurell
@topotropic topotropic removed the needs:UX-feedback Needs UX Feedback label Jan 14, 2021
joc-a added a commit to joc-a/fenix that referenced this issue Jan 15, 2021
@joc-a
For mozilla-mobile#16519: Add space above Delete History button
d2cff00 
add space above Delete History button
rocketsroger pushed a commit that referenced this issue Jan 15, 2021
@Mugurell @joc-a
For #16519: Add space above Delete History button (#17492)
d8dc1c4 
add space above Delete History button

Co-authored-by: Jocelyne Abi Haidar <jocelyne.ah1@gmail.com>
@Mugurell Mugurell added the eng:qa:needed QA Needed label Jan 15, 2021
@ebalazs-sv
Copy link

Verified as fixed on Nightly 1/19 with Samsung Galaxy Tab S3 (Android 8).
I will close this issue and remove the qa:needed label.
@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 19, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@Mugurell @joc-a @pkirakosyan
For mozilla-mobile#16519: Add space above Delete History button (mozi…
895260b 
…lla-mobile#17492)

add space above Delete History button

Co-authored-by: Jocelyne Abi Haidar <jocelyne.ah1@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download good first issue Good for newcomers
6 participants
@topotropic @cadeyrn @Mugurell @joc-a @ebalazs-sv @mcarare