The Wayback Machine - https://web.archive.org/web/20210215233741/https://github.com/EssentialsX/Essentials/pull/3694
Skip to content

/ Essentials

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for material tags in enchant signs #3694

Merged
merged 11 commits into from Feb 5, 2021
Merged

Add support for material tags in enchant signs #3694

merged 11 commits into from Feb 5, 2021

Conversation

@pop4959
Copy link
Member

@pop4959 pop4959 commented Oct 2, 2020

Closes #3653

Tested with "swords" and works on Paper. Didn't have the opportunity to test on Spigot, but should be working.
@pop4959
Add support for material tags in enchant signs
Loading status checks…
4656cbc
@darbyjack
darbyjack reviewed Oct 2, 2020
View changes
@JRoy
JRoy reviewed Oct 3, 2020
View changes
pop4959 added 2 commits Nov 26, 2020
@pop4959
Merge branch '2.x' into material-tags-in-enchant-signs
bc57e10
@pop4959
FiX
Loading status checks…
522b110
@pop4959 pop4959 dismissed stale reviews from JRoy and darbyjack via 522b110 Nov 26, 2020
pop4959 added 3 commits Nov 26, 2020
@pop4959
Re-add checkstyle file
Loading status checks…
b4784ba
@pop4959
Formatting
Loading status checks…
eb17568
@pop4959
ok
Loading status checks…
4fa45e4
@JRoy
JRoy reviewed Nov 26, 2020
View changes
@mdcfe mdcfe added this to the 2.19.0 milestone Nov 27, 2020
@mdcfe
mdcfe requested changes Nov 30, 2020
View changes
Essentials/src/main/java/com/earth2me/essentials/signs/SignEnchant.java Outdated Show resolved Hide resolved
JRoy added 2 commits Jan 27, 2021
@JRoy
Fix incompatibility on < 1.13
Verified
This commit was signed with a verified signature.
JRoy Josh Roy
GPG key ID: 86A69D08540BC29A Learn about signing commits
9587cef
@JRoy
Cache tag lookups
Verified
This commit was signed with a verified signature.
JRoy Josh Roy
GPG key ID: 86A69D08540BC29A Learn about signing commits
Loading status checks…
de84cbb
@JRoy JRoy dismissed their stale review via de84cbb Jan 27, 2021
JRoy added 2 commits Jan 27, 2021
@JRoy
Merge branch '2.x' into material-tags-in-enchant-signs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9f63e03
@JRoy
Fix codestyle violation
Verified
This commit was signed with a verified signature.
JRoy Josh Roy
GPG key ID: 86A69D08540BC29A Learn about signing commits
Loading status checks…
409ba7e
@JRoy
JRoy approved these changes Jan 27, 2021
View changes
@JRoy JRoy requested a review from mdcfe Jan 27, 2021
@mdcfe
mdcfe approved these changes Feb 5, 2021
View changes
@mdcfe
Merge branch '2.x' into material-tags-in-enchant-signs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f774168
@mdcfe mdcfe enabled auto-merge (squash) Feb 5, 2021
@mdcfe mdcfe merged commit cb168b0 into EssentialsX:2.x Feb 5, 2021
1 check passed
1 check passed
Build and upload
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement
5 participants
@pop4959 @mdcfe @JRoy @darbyjack @Chew