The Wayback Machine - https://web.archive.org/web/20201211215552/https://github.com/Unity-Technologies/com.unity.probuilder/pull/359
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB 5.0 bugfix collection #359

Merged
merged 5 commits into from Dec 11, 2020
Merged

PB 5.0 bugfix collection #359

merged 5 commits into from Dec 11, 2020

Conversation

@lopezt-unity
Copy link
Contributor

@lopezt-unity lopezt-unity commented Dec 3, 2020

Collection of bugfixes raised by PB 5.0 preview release

Purpose of this PR

Fixes for various bugs identified on the preview of PB 5.0

Links

Fogbugz:
https://fogbugz.unity3d.com/f/cases/1296422/
https://fogbugz.unity3d.com/f/cases/1296427/
https://fogbugz.unity3d.com/f/cases/1296428/
https://fogbugz.unity3d.com/f/cases/1296494/
https://fogbugz.unity3d.com/f/cases/1296104/

Comments to Reviewers

[List known issues, planned work, provide any extra context for your code.]

@lopezt-unity lopezt-unity requested a review from karl- as a code owner Dec 3, 2020
@karl-
karl- approved these changes Dec 3, 2020
lopezt-unity added 3 commits Dec 3, 2020
Changing rolloff from custom to linear
@lopezt-unity lopezt-unity requested review from karl- and JoelFortin Dec 4, 2020
@karl-
karl- approved these changes Dec 4, 2020
Copy link

@JoelFortin JoelFortin left a comment

Tested the five fixes in the PR ... LGTM

@lopezt-unity lopezt-unity merged commit 02131b0 into master Dec 11, 2020
8 checks passed
8 checks passed
[Yamato] Pack Succeeded
Details
[Yamato] Test 2019.4 on mac Succeeded
Details
[Yamato] Test 2019.4 on win Succeeded
Details
[Yamato] Test 2020.1 on mac Succeeded
Details
[Yamato] Test 2020.1 on win Succeeded
Details
[Yamato] Test trunk on mac Succeeded
Details
[Yamato] Test trunk on win Succeeded
Details
[Yamato] Tests Trigger Succeeded
Details
@lopezt-unity lopezt-unity deleted the bugfix/pb5-bugfix-collection branch Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.