Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMenu items for enabling pubsub and automatic GC #1647
Comments
|
I think if we have a UI based switch to turn on/off the flags such as Pubsub and GC etc then that would be better for end users as well. I am currently working on a framework that does require IPFS in the backend and needs the PUBSUB to be enabled. Since the framework also consists of demos for general public as well, it's difficult for users to find the configuration and update the flags. |
|
@shaikh-shahid that is very useful feedback, thank you. I think we could avoid enabling pubsub by default by adding on/off checkbox settings for pubsub (and automatic GC) to the Desktop app menu. Toggling would automatically restart the deamon with the new setting. |
jessicaschilling
changed the title
|
Note: Added mockup of menu item placement in original comment. Unless @aschmahmann or @autonome have objections, I believe this is ready to work. |
I was looking into starting go-ipfs with additional flags:
--enable-pubsub-experiment(pubsub) and--enable-namesys-pubsub(IPNS over pubsub) and the main concern I've found was use of resources:So if we want pubsub and fast IPNS enabled, we need to pay the cost of higher resource utilization.
We could measure it and decide if its worth the added value, or prioritize a fix.
Updated: or at the very least, we could give user UI for enabling that with one click
Updated again: See mockup for placement of menu items for pubsub and automatic GC (note this also includes not-yet-implemented "Ask when opening" menu item, likely to land first in #1646)
@aschmahmann are there any other concerns that I don't see?
@autonome FYSA this also impacts go-ipfs in Brave, especially the speed of
ipns://