The Wayback Machine - https://web.archive.org/web/20201206192707/https://github.com/pinojs/pino/issues/815
Skip to content

/ pino

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more clarification to the LTS doc #815

Open
jsumners opened this issue Apr 8, 2020 · 4 comments
Open

Add more clarification to the LTS doc #815

jsumners opened this issue Apr 8, 2020 · 4 comments
Labels
documentation good first issue

Comments

@jsumners
Copy link
Member

@jsumners jsumners commented Apr 8, 2020

I like the language about legacy versions and how they are are supported in https://github.com/googleapis/google-cloud-node#supported-nodejs-versions . I think we could adopt some form of it.
@mcollina
Copy link
Member

@mcollina mcollina commented Apr 8, 2020

I'm ok with that language as long as we clarify that we drop old Node.js versions in a major.
@jsumners
Copy link
Member Author

@jsumners jsumners commented Apr 8, 2020

Indeed. I’m suggesting keeping what we currently have and extending it with a version of what is linked.
@mcollina
Copy link
Member

@mcollina mcollina commented Apr 8, 2020

PR? Definitely good
@jsumners
Copy link
Member Author

@jsumners jsumners commented Apr 8, 2020

Yeah. This issue is a TODO for me in the future or easy fodder for a new contributor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation good first issue
2 participants
@mcollina @jsumners
You can’t perform that action at this time.