The Wayback Machine - https://web.archive.org/web/20201212011857/https://github.com/apache/apisix-dashboard/pull/1007
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): added commit message guidelines #1007

Merged
merged 1 commit into from Dec 10, 2020

Conversation

@juzhiyuan
Copy link
Member

@juzhiyuan juzhiyuan commented Dec 10, 2020

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Related issues
    resolve #659


Bugfix

  • Description

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 10, 2020

Codecov Report

Merging #1007 (f68cad5) into master (e611cd3) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
+ Coverage   43.96%   44.04%   +0.07%     
==========================================
  Files          18       18              
  Lines        1310     1310              
==========================================
+ Hits          576      577       +1     
+ Misses        643      642       -1     
  Partials       91       91              
Impacted Files Coverage Δ
api/internal/core/store/store.go 79.22% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e611cd3...f68cad5. Read the comment docs.

@LiteSun LiteSun merged commit 79c0c18 into master Dec 10, 2020
11 checks passed
11 checks passed
run-test run-test
Details
run-test run-test
Details
run-test run-test
Details
markdown-link-check markdown-link-check
Details
Frontend e2e test Frontend e2e test
Details
check-license check-license
Details
build (10.x) build (10.x)
Details
golangci golangci
Details
build (12.x) build (12.x)
Details
build (14.x) build (14.x)
Details
Semantic Pull Request ready to be squashed
Details
@LiteSun LiteSun deleted the juzhiyuan/docs-contributing branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.