`atan` versus `atan2` #166

SheetJSDev · 2020-05-29T01:03:10Z

Both dashed and zigzag use Math.atan:

      const alpha = Math.atan((p2[1] - p1[1]) / (p2[0] - p1[0]));

It would seem that a generated vertical line would cause errors. Is there a reason for preferring this over the safer atan2 alternative?

      const alpha = Math.atan2((p2[1] - p1[1]), (p2[0] - p1[0]));

pshihn · 2020-05-29T01:33:17Z

You're correct atan2 would be the better option here, because I don't check for the denominator to be nonzero.

pshihn · 2020-05-29T01:34:08Z

I think I have been getting away with it because it is unlikely in zigzag lines, and the randomness in the dashed lines.

rough-stuff / rough