The Wayback Machine - https://web.archive.org/web/20201114161946/https://github.com/tensorflow/tfjs/issues/1697
Skip to content

/ tfjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update batch norm reference in tfjs-node #1697

Open
nkreeger opened this issue Jun 26, 2019 · 5 comments
Open

Update batch norm reference in tfjs-node #1697

nkreeger opened this issue Jun 26, 2019 · 5 comments
Assignees
@kangyizhang
Labels
comp:node.js good first issue

Comments

@nkreeger
Copy link
Member

@nkreeger nkreeger commented Jun 26, 2019

Looks like a new OpDef is ready (and current one is deprecated):

tf.batchNormalization() is going away. Use tf.batchNorm() instead, and note the positional argument change of scale, offset, and varianceEpsilon You can disable deprecation warnings with tf.disableDeprecationWarnings().
tf.batchNormalization() is going away. Use tf.batchNorm() instead, and note the positional argument change of scale, offset, and varianceEpsilon You can disable deprecation warnings with tf.disableDeprecationWarnings().
@nkreeger nkreeger self-assigned this Jun 26, 2019
@theodddore
Copy link

@theodddore theodddore commented Jul 8, 2019

Hi, could I take a look at this as a first issue or @nkreeger is working on it?
@nkreeger
Copy link
Member Author

@nkreeger nkreeger commented Jul 8, 2019

@theodddore go for it! OpDef registry in core TF is here: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/ops/compat/ops_history.v1.pbtxt

We match up those OpDefs in the tfjs node backend for each op here:
https://github.com/tensorflow/tfjs-node/blob/master/src/nodejs_kernel_backend.ts#L1334
@nkreeger
Copy link
Member Author

@nkreeger nkreeger commented Jul 8, 2019

Actually - this might need to be a cleanup in tfjs-core:

$ git grep batchNormalization
...
src/ops/batchnorm_test.ts:907:describeWithFlags('deprecated batchNormalization', ALL_ENVS, () => {
src/ops/batchnorm_test.ts:917:    const result = tf.batchNormalization(
src/ops/batchnorm_test.ts:941:    const result2 = tf.batchNormalization2d(
src/tensor.ts:863:  batchNormalization(
src/tensor.ts:869:        'tf.batchNormalization() is going away. ' +
@theodddore
Copy link

@theodddore theodddore commented Jul 9, 2019

Hi, thanks for the tips. I'll start working on it!
@theodddore
Copy link

@theodddore theodddore commented Jul 21, 2019

Hi @nkreeger,

it seems that batchNormalization from backend is used by batchNorm (using the FusedBatchNorm opDef), so it's my understanding that we should just perform the cleanup you mentioned above in tfjs-core. If what I say is correct, should I remove batchNormalization also from src/tensor.ts, or is it needed as legacy code?
@tensorflow tensorflow deleted a comment from OVERSTANDING683 Sep 9, 2019
@rthadur rthadur assigned kangyizhang and unassigned nkreeger Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:node.js good first issue
3 participants
@nkreeger @kangyizhang @theodddore
You can’t perform that action at this time.