The Wayback Machine - https://web.archive.org/web/20201223105900/https://github.com/tfutils/tfenv/pull/127
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customizing the config directory via environment variable #127

Open
wants to merge 1 commit into
base: master
from

Conversation

@e-nomem
Copy link
Contributor

@e-nomem e-nomem commented Jul 25, 2019

This PR adds TFENV_CONFIG_DIR as an environment variable that can be customized. The use-gnupg, use-gpgv, and version files will all live under this directory, as will the versions directory where terraform binaries are installed.

This should close #66, which is caused by the fact that all those files and directories currently live under TFENV_ROOT, which can get blown away by a homebrew upgrade.

It incidentally also fixes a general issue where tfenv is globally installed on a system in a location where all users do not have write permissions, preventing them from installing user-specific versions of terraform.

@e-nomem
Copy link
Contributor Author

@e-nomem e-nomem commented Sep 13, 2019

Ping @Zordrak

@Zordrak
Copy link
Collaborator

@Zordrak Zordrak commented May 27, 2020

Apologies, I'm trying to work through the PR backlog. the v2.0.0 release has done significant damage to this PR, so will need time to look at how to fix it up and then assess the impact of the change

@e-nomem
Copy link
Contributor Author

@e-nomem e-nomem commented May 27, 2020

@Zordrak let me know if you have any issues with the way this feature is currently implemented in general, and I'll take some time in the next few days to rebase the PR and address the feedback at the same time.

@Zordrak
Copy link
Collaborator

@Zordrak Zordrak commented May 28, 2020

Seems reasonable in concept

@e-nomem e-nomem force-pushed the e-nomem:customize-config-dir branch from d72453c to 14608d4 May 29, 2020
@e-nomem
Copy link
Contributor Author

@e-nomem e-nomem commented May 29, 2020

Ok, I've fixed up the PR on the master branch

@anthraxx
Copy link

@anthraxx anthraxx commented Sep 23, 2020

data like terraform installation does not belong into XDG_CONFIG_HOME that's purely meant to contain configuration. That's what XDG_DATA_HOME is for, containing application data beyond pure configuration.
Orthogonal to that, data should go to a separate location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.