The Wayback Machine - https://web.archive.org/web/20201212040350/https://github.com/google/flatbuffers/pull/6234
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of rules_go to 0.24.5 #6234

Merged
merged 1 commit into from Nov 12, 2020
Merged

Conversation

@comius
Copy link
Contributor

@comius comius commented Nov 5, 2020

Versions of rules_go below 0.24 include platforms repository, which are lacking
definitions of os:macos, cpu:arm64 constraints.

This definitions are needed to properly select toolchains in latest
bazel.

Versions of rules_go below 0.24 include platforms repository, which are lacking
definitions of os:macos, cpu:arm64 constraints.

This definitions are needed to properly select toolchains in latest
bazel.
@comius
Copy link
Contributor Author

@comius comius commented Nov 9, 2020

friendly ping

@aardappel
Copy link
Collaborator

@aardappel aardappel commented Nov 10, 2020

@comius can you make a PR for this?

@comius
Copy link
Contributor Author

@comius comius commented Nov 11, 2020

@comius can you make a PR for this?

Sorry I don't understand, can you be more specific? I thought this was a PR.

@aardappel
Copy link
Collaborator

@aardappel aardappel commented Nov 12, 2020

Apologies, somehow thought this was an issue :p

@aardappel aardappel merged commit 33ab260 into google:master Nov 12, 2020
9 checks passed
9 checks passed
Build Linux (g++-9)
Details
label
Details
Build Linux (clang++-9)
Details
Build Windows Build Windows
Details
Build Mac
Details
buildkite/flatbuffers/pr Build #3029 passed (1 minute, 40 seconds)
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.