The Wayback Machine - https://web.archive.org/web/20201126010850/https://github.com/TheAlgorithms/Python/pull/2506
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imports for all namespace packages #2506

Merged
merged 3 commits into from Sep 28, 2020
Merged

Fix imports for all namespace packages #2506

merged 3 commits into from Sep 28, 2020

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Sep 28, 2020

As mentioned in #2503

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@dhruvmanila
Fix imports as they're namespace packages
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv Manilawala
GPG key ID: 9601911DE8797432 Learn about signing commits
Loading status checks…
caa014d
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Sep 28, 2020

Hey @dhruvmanila,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e4d88bf0-01b4-11eb-9be6-0d9634a5fbe7
@dhruvmanila
Fix import for scripts/validate_filenames.py
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv Manilawala
GPG key ID: 9601911DE8797432 Learn about signing commits
Loading status checks…
e2e45e5
@dhruvmanila
Copy link
Member Author

@dhruvmanila dhruvmanila commented Sep 28, 2020

Ok, some of the doctest are failing due to the change of paths.
@cclauss Should I fix it?
@cclauss
Copy link
Member

@cclauss cclauss commented Sep 28, 2020

Yes, please
@dhruvmanila
Fix path in doctest
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv Manilawala
GPG key ID: 9601911DE8797432 Learn about signing commits
Loading status checks…
0e48a10
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Sep 28, 2020

Travis tests have failed

Hey @dhruvmanila,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 38645890-01b9-11eb-9be6-0d9634a5fbe7
@dhruvmanila
Copy link
Member Author

@dhruvmanila dhruvmanila commented Sep 28, 2020

It seems like there's a doctest which is actually failing?
Can you take a look at it? https://travis-ci.com/github/TheAlgorithms/Python/jobs/392149978#L1300
@cclauss
@dhruvmanila
Copy link
Member Author

@dhruvmanila dhruvmanila commented Sep 28, 2020

Weird, it's passing when I run it locally.
@dhruvmanila
Copy link
Member Author

@dhruvmanila dhruvmanila commented Sep 28, 2020

Can you rerun the build? @cclauss
@cclauss
cclauss approved these changes Sep 28, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment

THANKS!!
@cclauss cclauss merged commit 9016fe1 into TheAlgorithms:master Sep 28, 2020
2 of 3 checks passed
2 of 3 checks passed
codespell
Details
Travis CI - Pull Request Build Failed
Details
Travis CI - Pull Request Build Passed
Details
@cclauss
Copy link
Member

@cclauss cclauss commented Sep 28, 2020

Travis is being flakey lately.
@dhruvmanila dhruvmanila deleted the dhruvmanila:patch-imports branch Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@dhruvmanila @TravisBuddy @cclauss
You can’t perform that action at this time.