The Wayback Machine - https://web.archive.org/web/20201126013330/https://github.com/TheAlgorithms/Python/pull/3803
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sum_of_digits.py #3803

Open
wants to merge 1 commit into
base: master
from
Open

Update sum_of_digits.py #3803

wants to merge 1 commit into from

Conversation

@sulochanaviji
Copy link

@sulochanaviji sulochanaviji commented Oct 28, 2020 •
edited

reverse function added

Describe your change:

Added reverse function which is used to find the reverse of the digits

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
    add one new function
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@sulochanaviji
Update sum_of_digits.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fd12af4 
reverse function added
@sulochanaviji sulochanaviji requested a review from Kush1101 as a code owner Oct 28, 2020
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 28, 2020

Travis tests have failed

Hey @sulochanaviji,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 82de1f50-18e3-11eb-86f8-31dd4df69769
@mrmaxguns
Copy link
Contributor

@mrmaxguns mrmaxguns commented Nov 5, 2020

Please check the code before submitting a pull request. The function you have added has invalid syntax (in the function declaration) and random uninstantiated variable names appearing in the function body.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@sulochanaviji @TravisBuddy @mrmaxguns
You can’t perform that action at this time.