The Wayback Machine - https://web.archive.org/web/20201127124925/https://github.com/SoftwareBrothers/admin-bro/pull/554
Skip to content

/ admin-bro

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add step, min and max props for number properties #554

Open
wants to merge 1 commit into
base: master
from
Open

feat: add step, min and max props for number properties #554

wants to merge 1 commit into from

Conversation

@maurocen
Copy link

@maurocen maurocen commented Aug 24, 2020

What this PR does

  • Adds step, min and max props when a property is of type number or float.
    • step defaults to 1
    • min/max default to Number.MIN_SAFE_INTEGER/Number.MAX_SAFE_INTEGER or Number.MIN_VALUE/Number.MAX_VALUE depending on the type being number or float
  • Properties are pulled from custom object in property declaration.
@maurocen
feat: add step, min and max props for number properties
284d737
@wojtek-krysiak
Copy link
Contributor

@wojtek-krysiak wojtek-krysiak commented Aug 24, 2020

It looks ok, but unfortunately, I cannot merge it :(. We have a plan for handling integers in a full approach:

  • create a new number type for edit and filter
  • create dedicated react component for numbers
  • update filter logic so it can handle greater than, less than, less or equal than etc

I will leave this open so it will be an inspiration for this feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@maurocen @wojtek-krysiak
You can’t perform that action at this time.