Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Replaced [String] dependency url with [Package.Dependency] #227
Conversation
The problem with [String] urls was that inside the Package specification, we were running a map function that was inserting major version 2 for all the URLS. This is not the best way to deal. Reason: What if in some near future we add 1 more dependency? Will that dependency also take 2 as major version? Likely not. Solution: The current approach adds the ability to add fully satisfied dependency without the explict knowledge of mapping over.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Problem Statement
The problem with [String] urls was that inside the Package
specification, we were running a map function that was inserting
major version 2 for all the URLS. This is not the best way to deal
although we only have 1 dependency at the moment.
Reason:
What if in some near future we add 1 more dependency?
Will that dependency also take 2 as major version? Likely not.
Solution:
The current approach adds the ability to add fully
satisfied dependency without the explicit knowledge of mapping over.