The Wayback Machine - https://web.archive.org/web/20201126011818/https://github.com/TheAlgorithms/Python/pull/3704
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move validate_solutions and add durations flag to pytest.ini #3704

Merged
merged 5 commits into from Oct 24, 2020
Merged

Move validate_solutions and add durations flag to pytest.ini #3704

merged 5 commits into from Oct 24, 2020

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 24, 2020

Describe your change:

  • Moved validate_solutions.py and project_euler_answers.json to scripts directory and other dependent changes.
  • Configure pytest.ini with the --durations flag to apply it everywhere.
  • Remove codespell and autoblack action as mentioned in #3447 (comment)
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
dhruvmanila added 4 commits Oct 24, 2020
@dhruvmanila
Move PE validate_solutions to scripts/ directory
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv Manilawala
GPG key ID: 9601911DE8797432 Learn about signing commits
7506e02
@dhruvmanila
Update pytest.ini file with durations settings
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv Manilawala
GPG key ID: 9601911DE8797432 Learn about signing commits
cd69d23
@dhruvmanila
Remove codespell and autoblack workflow file
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv Manilawala
GPG key ID: 9601911DE8797432 Learn about signing commits
bb4408d
@dhruvmanila
Dependent changes to test config files
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv Manilawala
GPG key ID: 9601911DE8797432 Learn about signing commits
Loading status checks…
0fbe955
@dhruvmanila dhruvmanila requested review from cclauss and Kush1101 as code owners Oct 24, 2020
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 24, 2020 •
edited

Moved validate_solutions.py and project_euler_answers.json to scripts directory

If these scripts are only used for GitHub Actions then my preference would be that they live in .github/workflows. Your thoughts?
@dhruvmanila
Copy link
Member Author

@dhruvmanila dhruvmanila commented Oct 24, 2020 •
edited

I think scripts is an appropriate place for them to be. Also, workflows is a special directory used by GitHub so I don't think we can put other files in it.
@cclauss
cclauss approved these changes Oct 24, 2020
View changes
@cclauss
cclauss reviewed Oct 24, 2020
View changes
pytest.ini Outdated Show resolved Hide resolved
@dhruvmanila
Update pytest.ini
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7854eea
@dhruvmanila dhruvmanila merged commit b97529d into TheAlgorithms:master Oct 24, 2020
4 checks passed
4 checks passed
project-euler
Details
pre-commit
Details
validate-solutions
Details
Travis CI - Pull Request Build Passed
Details
@dhruvmanila dhruvmanila deleted the dhruvmanila:move-validate-solutions branch Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: awaiting reviews Type: enhancement
2 participants
@dhruvmanila @cclauss
You can’t perform that action at this time.