Thank god i made my first ever github contribution, i was very difficult for a beginner, but i did it, jus please review it and merged it i will more happy if you will merged it thanks.

But cclauss thank you so much showing interest in my code before you nobody even tell me the problems with my code thank you again and i will be add these changes as you tell me .

So i got it what you suggest me is

1. return dictionary with value name instead value
2. doctest import is made inside main
3. Comments should be helpful for reader
4. And for wrong value input value error should be raised instead returning 0

Hey, @cclauss this is creating a new directory in the root.

If he gives an ok then @erdum please add an empty __init__.py file in the directory as well.

this is creating a new directory in the root.

Thanks for the heads up on that. I missed that detail and we should seriously consider if making a new root directory is the right thing to do. Would we consider this a conversion -- Not really. What other existing root directories would make sense for this contribution or should we really create a new root dir?

If this really needs a new directory then I think it should be physics.

Thinking about it, we can keep the number of directories same by putting the quantum directory in the physics.

There are tons of quantum algorithms that have nothing to do with physics.

I would be OK with adding electronics (there are tons of possible algorithms in that category) if we could get rid of something else... What about knapsack? That seems to be the weakest topic for a root directory. Where could we stuff the knapsack algorithms to make room for electronics?

https://www.researchgate.net/publication/269211254_The_analysis_and_optimization_algorithms_of_the_electronic_circuits_design

It seems that the images directory should be removed as we are not using Travis anymore.

There's also greedy_knapsack in the greedy_method directory.

This is my proposal:

• Remove images and greedy_method directory.
• Move greedy_knapsack to knapsack directory as there are multiple variations for the knapsack problem according to Wikipedia and multiple ways of solving as well.

And now i think you may don't want to add my contribution because i saw other PR just simple and you see it and just merged without any exception but with my case you nearly figured out every small detail, i don't think this is a great place for beginner to start with that's not the way to teach a beginner its just like you are boss and i am your employ, finally i just say what i realize is you have specific problem with me.

Very disappointment not expecting from a person who has lot's of experience, i expecting kindness and good teaching attitude but not always people are good

@erdum I think this PR is extremely close to being landed. I know it is a lot of work but we have a great repo here because we sweat the details. We were seriously overwhelmed by Hacktoberfest so we might have let thru things that were not at the highest level of quality but that is the exception, not the rule.

Thanks massively for your hard work and patience.

@cclauss if you all say to me before then i am not going to comment that but sorry if my words hutt you but i jus lost my patience .

Patience is a fragile thing. Your algorithm is now part of the repo. Thanks for that!

I am beginner to github its my first time ever contribution i don't even about the CI for testing my code i figured out by my own how to solve issue because my checks are failing but in first time i jus understand that the more your code is clean then more your code is to be good

Agreed. Our high standards make this a difficult repo for beginners to contribute to but we are trying to help people to quickly learn things like testing, type hints, good variable names, f-strings because they can make code more readable and more reliable. Other repos can be easier to contribute to but this repo tries to teach best practices.

yes I learned a lot from you and your repo thanks

The thing that I love is that this is not my repo... It is our repo. Now that your algorithm is in the repo, you are part of the club. The electronics directory currently only has one algorithm so please consider what else could be added.

Yes my next goal will be on kcl law, it is complicated so i will try to run it locally then i will make PR so you can test or debug my code

Now i realize you are a very nice person actually, so sorry for the previous comments