The Wayback Machine - https://web.archive.org/web/20201126010635/https://github.com/TheAlgorithms/Python/pull/3420
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed octal_to_decimal to octal_to_decimal.py #3420

Merged
merged 5 commits into from Nov 23, 2020
Merged

Renamed octal_to_decimal to octal_to_decimal.py #3420

merged 5 commits into from Nov 23, 2020

Conversation

@cybov
Copy link
Contributor

@cybov cybov commented Oct 17, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@cybov
Renamed octal_to_decimal to octal_to_decimal.py
Loading status checks…
e3e2f23
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 17, 2020

Travis tests have failed

Hey @cybov,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 1cfbba30-1041-11eb-af89-615b230ba186
cybov added 4 commits Oct 17, 2020
@cybov
Updated octal_to_decimal.py
Loading status checks…
a280191
@cybov
modified doctests
Loading status checks…
d20f6c1
@cybov
updated octal_to_decimal.py
Loading status checks…
ad0047a
@cybov
Merge branch 'master' of https://github.com/TheAlgorithms/Python
Loading status checks…
51df652
@cybov cybov mentioned this pull request Oct 18, 2020
Closed
0 of 2 tasks complete
@github-actions
Copy link

@github-actions github-actions bot commented Nov 16, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@github-actions github-actions bot added the stale label Nov 16, 2020
@dhruvmanila
dhruvmanila approved these changes Nov 23, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Oh wow! No idea how that happened but thanks for noticing it and fixing the filename.
@stale stale bot removed the stale label Nov 23, 2020
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 23, 2020

Ugh, found a bug!
@dhruvmanila dhruvmanila merged commit 49d0c41 into TheAlgorithms:master Nov 23, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@dhruvmanila dhruvmanila mentioned this pull request Nov 23, 2020
Closed
3 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@cybov @TravisBuddy @dhruvmanila
You can’t perform that action at this time.