The Wayback Machine - https://web.archive.org/web/20201126011158/https://github.com/TheAlgorithms/Python/pull/2948
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest: Add solution for Project Euler: Problem 89 #2948

Merged
merged 4 commits into from Nov 21, 2020
Merged

Hacktoberfest: Add solution for Project Euler: Problem 89 #2948

merged 4 commits into from Nov 21, 2020

Conversation

@coryallegory
Copy link
Contributor

@coryallegory coryallegory commented Oct 6, 2020 •
edited

Describe your change:

Adding a Python implementation for Project Euler problem 89
https://projecteuler.net/problem=89

Contributes to Issue #2695

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@coryallegory coryallegory force-pushed the coryallegory:euler89 branch 2 times, most recently from 5a9c5b2 to e737971 Oct 6, 2020
@coryallegory coryallegory changed the title add solution for euler problem 89 Add solution for Project Euler: Problem 89 Oct 6, 2020
@coryallegory coryallegory force-pushed the coryallegory:euler89 branch from e737971 to e0b048c Oct 6, 2020
@coryallegory coryallegory force-pushed the coryallegory:euler89 branch from 4d02368 to 17c6951 Oct 13, 2020
@dhruvmanila
dhruvmanila reviewed Oct 15, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Announcement:

@coryallegory

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.
@53jk1
53jk1 approved these changes Oct 22, 2020
View changes
@coryallegory coryallegory force-pushed the coryallegory:euler89 branch 2 times, most recently from 1c9b0af to eadd777 Oct 26, 2020
@coryallegory coryallegory changed the title Add solution for Project Euler: Problem 89 Hacktoberfest: Add solution for Project Euler: Problem 89 Oct 26, 2020
@dhruvmanila
dhruvmanila requested changes Nov 4, 2020
View changes
project_euler/problem_089/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_089/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_089/sol1.py Outdated Show resolved Hide resolved
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 4, 2020

Awesome work on making another file for testing! 🎉

There's still the merge conflict. You need to rebase on the latest commit from master.
@coryallegory coryallegory force-pushed the coryallegory:euler89 branch from f923b26 to 4e86f57 Nov 21, 2020
coryallegory added 2 commits Oct 6, 2020
@coryallegory
add solution for euler problem 89
3be741f
@coryallegory
updates to accommodate euler solution guideline updates
4b030e1
@coryallegory coryallegory force-pushed the coryallegory:euler89 branch 2 times, most recently from cc2f75e to b5be6d3 Nov 21, 2020
@coryallegory
use more descriptive vars
Loading status checks…
39267b4
@coryallegory coryallegory force-pushed the coryallegory:euler89 branch from 5600514 to 39267b4 Nov 21, 2020
github-actions github-actions
updating DIRECTORY.md
10b9e59
@coryallegory coryallegory requested a review from dhruvmanila Nov 21, 2020
@dhruvmanila
dhruvmanila approved these changes Nov 21, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Awesome work! Thanks for doing this :)
@dhruvmanila dhruvmanila merged commit b55e132 into TheAlgorithms:master Nov 21, 2020
@coryallegory coryallegory deleted the coryallegory:euler89 branch Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@coryallegory @dhruvmanila @53jk1
You can’t perform that action at this time.