Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Goldmine Problem with question link #3820
Open
Conversation
|
Here is why the pre-commit failed:
Travis failed because your program needed input while Pytest was running. Fix this issue by putting the algorithm in a function. |
|
|
||
| #Question Problem : https://leetcode.com/problems/path-with-maximum-gold/ | ||
|
|
||
| n = int(input().strip()) |
mrmaxguns
Nov 5, 2020
Contributor
One-letter variable names are not acceptable.
One-letter variable names are not acceptable.
| n = int(input().strip()) | ||
| m = int(input().strip()) | ||
| arr = [[0]*m for _ in range(n)] | ||
| print(arr) |
mrmaxguns
Nov 5, 2020
Contributor
Algorithms should not have any side-effects. Consider creating two functions: one for the algorithm itself, and another that invokes this function and prints output.
Algorithms should not have any side-effects. Consider creating two functions: one for the algorithm itself, and another that invokes this function and prints output.
| for i in range(n): | ||
| arr[i] = [int(j) for j in input().strip().split(" ")] | ||
|
|
||
| dp = [[0]*m for _ in range(n)] |
mrmaxguns
Nov 5, 2020
Contributor
Do not use abbreviations for variable names. Readability is key when writing code
Do not use abbreviations for variable names. Readability is key when writing code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.