The Wayback Machine - https://web.archive.org/web/20201125010916/https://github.com/TheAlgorithms/Python/pull/3903
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update related to the change in CI testing #3903

Merged
merged 2 commits into from Nov 19, 2020
Merged

Update related to the change in CI testing #3903

merged 2 commits into from Nov 19, 2020

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 19, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
dhruvmanila added 2 commits Nov 19, 2020
@dhruvmanila
Update README badge for GitHub CI
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv Manilawala
GPG key ID: 9601911DE8797432 Learn about signing commits
4618445
@dhruvmanila
Run GitHub CI everyday as was done in Travis
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv Manilawala
GPG key ID: 9601911DE8797432 Learn about signing commits
Loading status checks…
b934c0b
@dhruvmanila dhruvmanila requested a review from cclauss as a code owner Nov 19, 2020
@dhruvmanila
Copy link
Member Author

@dhruvmanila dhruvmanila commented Nov 19, 2020

@cclauss Please take a look at this. Also, the stale action is not closing any issues or pull requests, only marking them. Maybe we should switch to the stale bot (https://github.com/probot/stale)
@cclauss
cclauss approved these changes Nov 19, 2020
View changes
@dhruvmanila dhruvmanila merged commit fe68859 into TheAlgorithms:master Nov 19, 2020
2 checks passed
2 checks passed
build build
Details
pre-commit pre-commit
Details
@dhruvmanila dhruvmanila deleted the dhruvmanila:ci-related-updates branch Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@dhruvmanila @cclauss
You can’t perform that action at this time.