The Wayback Machine - https://web.archive.org/web/20201125011948/https://github.com/TheAlgorithms/Python/pull/3922
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stalebot to take 5 actions per hour #3922

Open
wants to merge 2 commits into
base: master
from
Open

Update stalebot to take 5 actions per hour #3922

wants to merge 2 commits into from
+2 −1

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 22, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@dhruvmanila
Update stalebot to take 5 actions per hour
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fc53ab9
@dhruvmanila dhruvmanila requested a review from cclauss as a code owner Nov 22, 2020
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
729814b
@cclauss
Copy link
Member

@cclauss cclauss commented Nov 22, 2020

I was thinking 5 PRs a day, not every hour. Do we really need to run this job every hour?
@dhruvmanila
Copy link
Member Author

@dhruvmanila dhruvmanila commented Nov 22, 2020

That is not up to us. This job runs every hour because of the rate limit and is scheduled directly into the code. As mentioned, the important parameters are daysUntilStale and daysUntilClose. limitPerRun is only used to determine how quickly you want the bot to label/close.

Why per hour? The bot requires a token to do its job and that token lasts for one hour plus there are rate limits and also the app could be blocked if GitHub finds it abusing the limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: awaiting reviews
2 participants
@dhruvmanila @cclauss
You can’t perform that action at this time.