The Wayback Machine - https://web.archive.org/web/20200914090848/https://github.com/knaxus/problem-solving-javascript/issues/40
Skip to content

/ problem-solving-javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Test for - Caeser Cipher #40

Open
TheSTL opened this issue Oct 7, 2019 · 7 comments 路 May be fixed by #57
Open

Add Unit Test for - Caeser Cipher #40

TheSTL opened this issue Oct 7, 2019 · 7 comments 路 May be fixed by #57
Labels
claimed-already good first issue

Comments

@TheSTL
Copy link
Member

@TheSTL TheSTL commented Oct 7, 2019 •
edited

馃ぁ What is required?

The algorithm is here : Caeser Cipher

  • Follow the ESLint rules strictly
  • Follow the filename and folder structure strictly
  • Since the Contribution Guide is not ready yet, go through the codebase pattern and add tests accordingly

Thank You!
@fcosueza
Copy link

@fcosueza fcosueza commented Oct 7, 2019

I can work on this. 馃憤
@ashokdey
Copy link
Member

@ashokdey ashokdey commented Oct 7, 2019

Sure @fcosueza, I have assigned this issue to you.
@fcosueza
Copy link

@fcosueza fcosueza commented Oct 7, 2019

Thanks !! 馃槂
@fcosueza
Copy link

@fcosueza fcosueza commented Oct 7, 2019 •
edited

Caesar cipher should raise and error when second argument is not a number, instead it's returning a string of "undefinedundefinedundefined". Also, the folder is misspelled "caeser". Should i correct it or make a new issue ?
@TheSTL
Copy link
Member Author

@TheSTL TheSTL commented Oct 7, 2019

@fcosueza
You should make a new issue for this and correct it in a new PR.
@ashokdey ashokdey mentioned this issue Oct 7, 2019
Open
@Omkaragrawal
Copy link

@Omkaragrawal Omkaragrawal commented Oct 8, 2019

Hey,
I would like to take this task.
@ashokdey
Copy link
Member

@ashokdey ashokdey commented Oct 8, 2019

Hey,
I would like to take this task.

Hey, @Omkaragrawal I have assigned you the fix and you can continue from there.
@Omkaragrawal Omkaragrawal linked a pull request that will close this issue Oct 8, 2019
Open
@fcosueza fcosueza removed their assignment Oct 9, 2019
@ashokdey ashokdey removed the Hacktoberfest label Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimed-already good first issue
4 participants
@fcosueza @ashokdey @Omkaragrawal @TheSTL
You can鈥檛 perform that action at this time.