Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add animationType to BatchUpdates #177
Conversation
… / deleteRows / reloadRows / insertSections / deleteSections / reloadSections
|
Hi ! Still no news since january 4th for my PR, maybe I missed something or I have to ask for a review ? Regards, |
| @@ -120,27 +120,27 @@ extension UITableView: ReloadableView { | |||
|
|
|||
| // Update items. | |||
| if batchUpdates.insertItems.count > 0 { | |||
| insertRows(at: batchUpdates.insertItems, with: .automatic) | |||
| insertRows(at: batchUpdates.insertItems, with: batchUpdates.animationType) | |||
staguer
Apr 20, 2018
Contributor
Can we control the animations on the collection view in a similar way? See line 70 in this file.
Can we control the animations on the collection view in a similar way? See line 70 in this file.
fmirault
Apr 27, 2018
Author
Unfortunately, in UIKit collection view doesn't have the same animation properties, you can only insert / delete / reload / move without any more possibility. :( That's why I only updated table view animations
Unfortunately, in UIKit collection view doesn't have the same animation properties, you can only insert / delete / reload / move without any more possibility. :( That's why I only updated table view animations
fmirault
Jul 2, 2018
Author
More than 2 months since my last answer... Could you please at least read it ?
More than 2 months since my last answer... Could you please at least read it ?
|
Apologies for the delay, @fmirault . I added a comment. This adapter is used for both table views and collection views, so it'd be odd to have a property that has no effect in some cases. Would it be possible to make it (or something like it) work in both cases? |
|
Collection View isn't working like Table View, so I don't really see how I can achieve the same effect on it (it's an UIKit limitation in my opinion). |
and use it for insertRows / deleteRows / reloadRows / insertSections / deleteSections / reloadSections methods.
Possible addition to #124 for animations.