WebApp for Containers template #8054

mgnsm · 2020-08-30T20:34:20Z

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

- Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

A new quickstart template that deploys a WebApp for Containers app service that authenticates to an Azure Container Registry (ACR) using a service principal.
The service principal must be created before using the template. There is a sample Bash script included in 101-webapp-for-containers\scripts that demonstrates how to deploy all required resources.
There is a prereqs template included for creating the ACR.

microsoft-cla · 2020-08-30T20:34:34Z

All CLA requirements met.

mgnsm · 2020-08-30T21:21:44Z

Are templates that require the existence of a service principal supposed to be validated manually?

The "Deploy Template (prereqs)" step fails with a PrincipalNotFound code which makes sense as the service principal must be created before the Azure Container Registry (ACR) resource.

Please advise how to proceed to get this PR accepted and merged.

MCKLMT · 2020-08-31T04:54:19Z

You should be able to use GEN-AZUREAD-OBJECTID to replace GEN-GUID for parameter servicePrincipalObjectId in prereq.azuredeploy.parameters.json.
This value will be replaced by the CI before deploying the template. I hope this help.

…pal object id.

mgnsm · 2020-08-31T06:35:42Z

Thanks for the suggestion. This placeholder should probably be mentioned in the contribution guidelines.

Now the validation of the prereqs template succeeds. The deployment validation of the main template however fails with an AccessToContainerRegistryDenied error code.

How are the appId and password of the required service principal supposed to be passed to/used in the build pipeline?

MCKLMT · 2020-08-31T10:44:57Z

You can find all the placeholders there: https://github.com/Azure/azure-quickstart-templates/blob/master/test/ci-gen-setup/.config.json
They will be replaced by the CI before deploying the template.

mgnsm · 2020-09-01T07:19:03Z

@MCKLMT Yes, using the GEN-AZUREAD-OBJECTID placeholder works for the prereqs template.

It still doens't create an actual service principal which is required for the validation of the main template to succeed.

So the question remains, should I set the validation type to "Manual" in the metadata.json file for the PR to be accepted and merged or how to proceed?

MCKLMT · 2020-09-01T07:35:34Z

@bmoore-msft Can you provide guidance to @mgnsm to get his PR validated please?

bmoore-msft · 2020-09-26T22:25:11Z

I updated the param files to use the existing SP, there is another failure now that looks like configuration (that I'm not familiar with...

mgnsm · 2020-09-28T08:44:40Z

@bmoore-msft

It fails becase there is no container uploaded to the ACR.

So in between the deployment of the prereqs template (ACR) and the actual template (WebApp), an image has to be uploaded to the ACR for the WebApp to be able to fetch it. The script does this:

az acr build . \
  --registry acrName  \
  --file Dockerfile \
  --image "imageName:latest"

How to do the same in the build pipeline, i.e. run a custom Bash script in between the deployment of the prereqs template and the main template?

101-webapp-for-containers/scripts/Dockerfile

bmoore-msft · 2020-09-28T17:48:39Z

101-webapp-for-containers/scripts/deploy.sh

+password=$(az ad sp create-for-rbac --name $servicePrincipalName --skip-assignment --query password --output tsv)
+appId=$(az ad sp show --id $servicePrincipalName --query appId --output tsv)
+servicePrincipalObjectId=$(az ad sp show --id $appId --query objectId --output tsv)
+


remove this file, or if you want to keep if for svc principal creation, remove everything after line 11

The Bash script is provided as an example of how to deploy the template including the prereqs outside the context of this repository. It's not meant to be used in the validation of the template itself.

Should I perhaps rename the folder to something else than scripts?

All templates in the repo are deployed the same inside and outside of the repo - having every sample provide their own deployment script creates confusion and a maintenance problem...

I removed the script and added instructions for how to deploy the resources in the README file. The build fails for some reason?

101-webapp-for-containers/azuredeploy.json

bmoore-msft · 2020-09-28T17:48:39Z

101-webapp-for-containers/README.md

+
+Before you use it, you should create a service principal and an ACR using the [pre-requisite template](prereqs/prereq.azuredeploy.json).
+
+You can use [this Bash script](scripts/deploy.sh) to deploy all required resources. The script uses the Azure CLI to do the following: 


update this when you remove the script

bmoore-msft · 2020-11-06T17:56:37Z

101-webapp-for-containers/scripts/deploy.sh

+password=$(az ad sp create-for-rbac --name $servicePrincipalName --skip-assignment --query password --output tsv)
+appId=$(az ad sp show --id $servicePrincipalName --query appId --output tsv)
+servicePrincipalObjectId=$(az ad sp show --id $appId --query objectId --output tsv)
+


All templates in the repo are deployed the same inside and outside of the repo - having every sample provide their own deployment script creates confusion and a maintenance problem...

msftbot · 2020-11-21T23:01:10Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

WebApp for Containers template

Loading status checks…

3a34e41

mgnsm added 3 commits Aug 30, 2020

Added missing badge in README.md

a77a146

maxValue for the skuCapacity parameter

Loading status checks…

b2322b8

Added badges for Azure US Gov

Loading status checks…

e5b6d17

Use the GEN-AZUREAD-OBJECTID placeholder to generate a service princi…

Loading status checks…

a4e964e

…pal object id.

bmoore-msft added 3 commits Sep 26, 2020

Update prereq.azuredeploy.parameters.json

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

7cf69f7

Update azuredeploy.parameters.json

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

080c096

Update azuredeploy.parameters.json

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

bfadd98

bmoore-msft added 2 commits Sep 28, 2020

add container image creation via deploymentScript

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

e6b5531

Update azuredeploy.parameters.json

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

0929c7c

bmoore-msft requested changes Sep 28, 2020

View changes

mgnsm added 5 commits Sep 29, 2020

Changed type to secureString.

f154c47

Moved dependsOn above properties.

Loading status checks…

9914a31

Import the image from a public container registry.

Loading status checks…

38b8220

Updated README.md.

4bcd02c

Moved the required appSettings to a variable.

Loading status checks…

ca49148

mgnsm requested a review from bmoore-msft Nov 6, 2020

bmoore-msft requested changes Nov 6, 2020

View changes

msftbot bot added the needs/author feedback label Nov 6, 2020

msftbot bot added the status/no recent activity label Nov 21, 2020

Removed the deployment script.

Loading status checks…

ea81e85

msftbot bot removed needs/author feedback status/no recent activity labels Nov 23, 2020

Updated dateUpdated in metadata.json.

Loading status checks…

70d3b06

Oct	NOV	Dec
	24
2019	2020	2021

Azure / azure-quickstart-templates

WebApp for Containers template #8054

WebApp for Containers template #8054

mgnsm commented Aug 30, 2020

microsoft-cla bot commented Aug 30, 2020 •

edited

mgnsm commented Aug 30, 2020

MCKLMT commented Aug 31, 2020

mgnsm commented Aug 31, 2020

MCKLMT commented Aug 31, 2020

mgnsm commented Sep 1, 2020

MCKLMT commented Sep 1, 2020

bmoore-msft commented Sep 26, 2020

mgnsm commented Sep 28, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

msftbot bot commented Nov 21, 2020


		Before you use it, you should create a service principal and an ACR using the [pre-requisite template](prereqs/prereq.azuredeploy.json).

		You can use [this Bash script](scripts/deploy.sh) to deploy all required resources. The script uses the Azure CLI to do the following:

Azure / azure-quickstart-templates

Join GitHub today

GitHub is where the world builds software

WebApp for Containers template #8054

WebApp for Containers template #8054

Conversation

mgnsm commented Aug 30, 2020

PR Checklist

Changelog

microsoft-cla bot commented Aug 30, 2020 • edited

mgnsm commented Aug 30, 2020

MCKLMT commented Aug 31, 2020

mgnsm commented Aug 31, 2020

MCKLMT commented Aug 31, 2020

mgnsm commented Sep 1, 2020

MCKLMT commented Sep 1, 2020

bmoore-msft commented Sep 26, 2020

mgnsm commented Sep 28, 2020

This comment has been minimized.

bmoore-msft Sep 28, 2020 Collaborator

This comment has been minimized.

mgnsm Sep 29, 2020 • edited Author

This comment has been minimized.

bmoore-msft Nov 6, 2020 Collaborator

This comment has been minimized.

mgnsm Nov 23, 2020 Author

This comment has been minimized.

bmoore-msft Sep 28, 2020 Collaborator

This comment has been minimized.

bmoore-msft Nov 6, 2020 Collaborator

msftbot bot commented Nov 21, 2020

Essential cookies

Always active

Analytics cookies

microsoft-cla bot commented Aug 30, 2020 •

edited

bmoore-msft Sep 28, 2020
Collaborator

mgnsm Sep 29, 2020 •

edited

Author

bmoore-msft Nov 6, 2020
Collaborator

mgnsm Nov 23, 2020
Author

bmoore-msft Sep 28, 2020
Collaborator

bmoore-msft Nov 6, 2020
Collaborator