The Wayback Machine - https://web.archive.org/web/20201215182831/https://github.com/ngrx/platform/issues/2576
Skip to content

/ platform

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Suggestion to use Labeler #2576

Open
BioPhoton opened this issue Jun 11, 2020 · 4 comments
Open

Docs: Suggestion to use Labeler #2576

BioPhoton opened this issue Jun 11, 2020 · 4 comments
Labels
Accepting PRs Good First Issue

Comments

@BioPhoton
Copy link
Contributor

@BioPhoton BioPhoton commented Jun 11, 2020

I thought I open an issue for that as I believe it can save the team a lot of work.

https://github.com/actions/labeler

If this is interesting I would contribute with the workflow file.

Just let me know what you think.
@timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Jun 11, 2020

I like it, I think this can be a great help to filter out PRs 👍
@BioPhoton
Copy link
Contributor Author

@BioPhoton BioPhoton commented Jun 11, 2020

Nice!
I'll see what I can do.
😁
@BioPhoton
Copy link
Contributor Author

@BioPhoton BioPhoton commented Jun 13, 2020

@brandonroberts @timdeschryver
Let me know how to proceed.

I would add the following things to the .github folder:

.github
  - labeler.yml
  workflows
    - label.yml

labeler.yml

# Add 'Project: ngrx.io' label to any ngrx.io file changes
  'Project: ngrx.io':
     - projets/ngrx.io/*
     - projets/ngrx.io/**/*

# Add 'Project: Example App' label to any example-app file changes
  'Project: Example App':
    - projets/example-app/*
    - projets/example-app/**/*

# Add 'Project: Component' label to any change within the 'component' package
  'Project: Component':
     - modules/component/*
     - modules/component/**/*

# Add 'Project: Component Store' label to any change within the 'component-store' package
  'Project: Component Store':
     - modules/component-store/*
     - modules/component-store/**/*

# Add 'Project: Data' label to any change within the 'data' package
  'Project: Data':
    - modules/data/*
    - modules/data/**/*

# Add 'Project: Effects' label to any change within the 'effects' package
  'Project: Effects':
    - modules/effects/*
    - modules/effects/**/*

# Add 'Project: Router Store' label to any change within the 'router-store' package
  'Project: Router Store':
    - modules/data/*
    - modules/data/**/*

# Add 'Project: Schematics' label to any change within the 'schematics' package
  'Project: Schematics':
    - modules/schematics/*
    - modules/schematics/**/*

# Add 'Project: Store' label to any change within the 'store' package
  'Project: Store':
    - modules/store/*
    - modules/store/**/*

# Add 'Project: Store Devtools' label to any change within the 'store-devtools' package
  'Project: Store Devtools':
    - modules/store-devtools/*
    - modules/store-devtools/**/*

# Add 'dependencies' label to any change to npm or yarn related stuff
  dependencies:
     - package.json
     - yarn.lock

label.yml

# This workflow will triage pull requests and apply a label based on the
# paths that are modified in the pull request.
#
# The used configurations are set up in .github/labeler.yml
# For more information, see:
# https://github.com/actions/labeler/blob/master/README.md

name: Labeler
on: [pull_request]

jobs:
  label:

    runs-on: ubuntu-latest

    steps:
    - uses: actions/labeler@v2
      with:
        repo-token: "${{ secrets.GITHUB_TOKEN }}"
@timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Jun 13, 2020

Seems fine to me @BioPhoton , what do you think @brandonroberts ?

There's one typo:

  'Project: Router Store':
    - modules/data/*
    - modules/data/**/*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs Good First Issue
3 participants
@brandonroberts @BioPhoton @timdeschryver
You can’t perform that action at this time.