The Wayback Machine - https://web.archive.org/web/20201018010322/https://github.com/segmentio/evergreen/pull/505
Skip to content

/ evergreen

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix proptype warning and rm package lock because yarn #505

Merged
merged 2 commits into from Feb 25, 2019
Merged

fix proptype warning and rm package lock because yarn #505

merged 2 commits into from Feb 25, 2019

Conversation

@mshwery
Copy link
Contributor

@mshwery mshwery commented Feb 25, 2019

This resolves the proptype warning from #504

I also removed the package-lock.json which got added at some point (unsure if intentional)
@mshwery
fix proptype warning and rm package lock because yarn
Loading status checks…
f8d78f9
@mshwery mshwery requested a review from notfelineit Feb 25, 2019
@vadimdemedes
Copy link
Contributor

@vadimdemedes vadimdemedes commented Feb 25, 2019

If you're removing package-lock.json in this PR anyway, could you also add .npmrc with package-lock=false content to prevent anyone from ever creating package-lock.json again?
@vadimdemedes
vadimdemedes approved these changes Feb 25, 2019
View changes
@mshwery
Copy link
Contributor Author

@mshwery mshwery commented Feb 25, 2019

@vadimdemedes excellent, will do.
@notfelineit
notfelineit approved these changes Feb 25, 2019
View changes
Copy link
Contributor

@notfelineit notfelineit left a comment

Thanks Matt :-)
@mshwery
add npmrc with package-lock=false
Loading status checks…
ae359d6
@mshwery mshwery merged commit 541e248 into master Feb 25, 2019
5 checks passed
5 checks passed
ci/circleci: test Your tests passed on CircleCI!
Details
license/snyk - docs/package.json (Segment) No manifest changes detected
license/snyk - examples/ssr-next/package.json (Segment) No manifest changes detected
security/snyk - docs/package.json (Segment) No manifest changes detected
security/snyk - examples/ssr-next/package.json (Segment) No manifest changes detected
@mshwery mshwery deleted the task/minor-fixes branch Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@mshwery @vadimdemedes @notfelineit
You can’t perform that action at this time.