The Wayback Machine - https://web.archive.org/web/20200916020744/https://github.com/hyperium/hyper/issues/2279
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEAD request using http/2 fails on bodies that don't implement is_end_stream #2279

Open
jeromegn opened this issue Sep 10, 2020 · 1 comment
Open

Comments

@jeromegn
Copy link

@jeromegn jeromegn commented Sep 10, 2020

Trying to do a HEAD request on an http/2 server that uses response bodies that don't implement HttpBody::is_end_stream (so that it sometimes return true) fail with an http2 protocol error.

I noticed this while wrapping a hyper::Body but not passing though is_end_stream

@seanmonstar
Copy link
Member

@seanmonstar seanmonstar commented Sep 10, 2020

Yea, we should update the proto::h2::client module to check for HEAD requests, like h1 does, and if so, then assume there can't be any request body at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.