The Wayback Machine - https://web.archive.org/web/20201115041019/https://github.com/octobercms/october/issues/5300
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong var type #5300

Open
davodsaraei opened this issue Oct 7, 2020 · 4 comments
Open

Wrong var type #5300

davodsaraei opened this issue Oct 7, 2020 · 4 comments

Comments

@davodsaraei
Copy link

@davodsaraei davodsaraei commented Oct 7, 2020

In this line, The $config variable defined as an array but used as an object

* @var array Supplied configuration.

@LukeTowers
Copy link
Member

@LukeTowers LukeTowers commented Oct 7, 2020

@SaidiAli
Copy link

@SaidiAli SaidiAli commented Oct 8, 2020

@davodsaraei I think it's intended to be used as an object. The array is turned into an object in this method; https://github.com/octobercms/october/blob/af6db51b79/modules/system/traits/ConfigMaker.php#L30

@davodsaraei
Copy link
Author

@davodsaraei davodsaraei commented Oct 8, 2020

@SaidiAli @LukeTowers It will be changed to object but I have another issue when I run the composer install.
#5302 (comment)

@LukeTowers
Copy link
Member

@LukeTowers LukeTowers commented Oct 8, 2020

@davodsaraei see my comment on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.