The Wayback Machine - https://web.archive.org/web/20201118072411/https://github.com/go-task/task/issues/395
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is `go get` not supported? #395

Open
slimsag opened this issue Nov 3, 2020 · 1 comment
Open

Why is `go get` not supported? #395

slimsag opened this issue Nov 3, 2020 · 1 comment

Comments

@slimsag
Copy link

@slimsag slimsag commented Nov 3, 2020

Hello, first let me say I really like Task and hope to contribute to it and get more adoption of it in my OSS projects (and in my work @sourcegraph where possible.)

One aspect that confuses me a bit is that the installation docs explicitly mention it cannot be installed via go get:

Task requires Go Modules and doesn’t officially support installing via go get anymore.

From what I can tell, nothing about Task prevents go get from working and in fact go get -u github.com/go-task/task/cmd/task works perfectly fine today - so long as you are running a recent Go version with module support (which I imagine most are at this point.)

I totally understand the binary options being suggested by default, but it's weird to say it doesn't officially support go get because it makes me (and I imagine others) think that:

  • Task has some very complex build process that doesn't work with go get
  • Task has some non-idiomatic Go code
  • Task requires CGO dependencies that can't be built with go get

It seems i haven't been the first with this thought before, as well: #250 (comment)

My suggestion is to do one of the following:

  1. Declare that go get -u github.com/go-task/task/cmd/task works - because it does and this is often the preferred installation method of many Gophers.
  2. OR at least don't declare that it isn't supported, because this makes me think it doesn't work and gives me a more negative view of Task which does it a disservice. It's a really great tool and I want to see it adopted more :)
@andreynering
Copy link
Contributor

@andreynering andreynering commented Nov 8, 2020

Hi @slimsag, thanks for opening this issue!

You're totally right! I think we could change the documentation to tell that go get is actually supported.

That was written in the early days of Go Modules, and I think I misunderstood that go get actually supports Go Modules.

Contributions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.