The Wayback Machine - https://web.archive.org/web/20201114210549/https://github.com/vozbu/libslave/pull/22
Skip to content

/ libslave

forked from Begun/libslave
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for alter query in non-default database v2 #22

Merged
merged 2 commits into from Jun 15, 2020
Merged

Fix for alter query in non-default database v2 #22

merged 2 commits into from Jun 15, 2020

Conversation

@aarchetype
Copy link

@aarchetype aarchetype commented Jun 14, 2020

Database name in binary log QUERY_EVENT is the default database name (see https://dev.mysql.com/doc/internals/en/event-data-for-specific-event-types.html ).
One should use database name from query with fallback to the default
database name from QUERY_EVENT.

Also std::pairstd::string,std::string was replaced with struct TableKey to improve readability.
aarchetype added 2 commits Jun 13, 2020
@aarchetype
Replace std::pair<std::string, std::string> with struct TableKey
baeb039
@aarchetype
Fix for alter query in non-default database.
13b6863 
Database name in binary log QUERY_EVENT is the default database name.
One should use database name from query with fallback to the default
database name from QUERY_EVENT.
@vozbu
Copy link
Owner

@vozbu vozbu commented Jun 15, 2020

Great! Thanks for switching to TableKey across all the code.
@vozbu vozbu merged commit 3c262ba into vozbu:master Jun 15, 2020
@vozbu vozbu mentioned this pull request Jun 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@aarchetype @vozbu
You can’t perform that action at this time.