The Wayback Machine - https://web.archive.org/web/20210124210245/https://github.com/APIDevTools/json-schema-ref-parser/pull/197
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stripQuery method and strip the query from the extension #197

Merged
merged 2 commits into from Jan 18, 2021

Conversation

@mathieudutour
Copy link
Contributor

@mathieudutour mathieudutour commented Nov 9, 2020

Given a url https://example.com/file.yml?foo=bar, the extension will be parsed as .yml?foo=bar and the relevant parsers will miss it.

This PR fixes this issue by stripping the query from the extension.

Copy link
Member

@P0lip P0lip left a comment

The code looks good.
Would you mind adding a small test for it?

@mathieudutour mathieudutour force-pushed the mathieudutour:patch-1 branch from 0c65c03 to 27d3364 Dec 10, 2020
@mathieudutour
Copy link
Contributor Author

@mathieudutour mathieudutour commented Dec 10, 2020

done 👍

@mathieudutour mathieudutour requested a review from P0lip Dec 16, 2020
@philsturgeon
Copy link
Member

@philsturgeon philsturgeon commented Jan 11, 2021

Thank you @mathieudutour!

@philsturgeon philsturgeon merged commit 0b1a08d into APIDevTools:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants