The Wayback Machine - https://web.archive.org/web/20201113042100/https://github.com/atom/atom/issues/21049
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Octicons to v10.0.0 #21049

Open
johnletey opened this issue Jul 7, 2020 · 11 comments
Open

Update Octicons to v10.0.0 #21049

johnletey opened this issue Jul 7, 2020 · 11 comments

Comments

@johnletey
Copy link

@johnletey johnletey commented Jul 7, 2020

Summary

GitHub has recently released some new snazzy octicons, and would love to see them in Atom!

Motivation

To look more cutting edge 馃槏

Describe alternatives you've considered

Additional context

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 4, 2020

I would like to work on this as part of Hactoberfest and to start my experience on open source. I'm working on Atom local setup and can you kindly explain to me what to achieve in this issue?. that would be helpful for me to get a start.

@sadick254
Copy link
Contributor

@sadick254 sadick254 commented Oct 5, 2020

Hey @gopipofficial the best place to start would be

.octicon-font-legacy() {
font-family: 'Octicons Regular';
src: url("icons/octicons-2.1.2.woff") format("woff");
font-weight: normal;
font-style: normal;
}
.octicon-font() {
font-family: 'Octicons Regular';
src: url("icons/octicons.woff") format("woff");
font-weight: normal;
font-style: normal;
}

However looking at the direction that github took to deliver octicons as svg rather than icon fonts, working on this would require a rework on how atom uses the icons.

Apologies I miss labeled this issue. If you are still willing to proceed working on this issue let me know.

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 7, 2020

I'll try my level best to achieve this before to start I'm having local setup issue working on it. Please give me sometime.

@pavan5555
Copy link

@pavan5555 pavan5555 commented Oct 8, 2020

hi @gopipofficial are you working on this ?

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 8, 2020

Yes, @pavan5555 ill be working on it. Unfortunately, I'm facing an atom local setup issue. Once I fixed that ill start working on it.

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 9, 2020

@sadick254 I regret to say this, I'm still facing an issue with the local setup. I've opened one issue for getting help on that.

@Moe82
Copy link

@Moe82 Moe82 commented Oct 21, 2020

Hi, @gopipofficial . Are you still working on this?

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 22, 2020

@Moe82 my local environment setup issue was fixed with the help of @sadick254 and now I started looking into the issue.

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 22, 2020

@sadick254 thanks for your input on setting up the local env. now its up and wanted to fix this issue. the issue is to change all the icons in the Atom from font icon to new octicons respectively right ???

@sadick254
Copy link
Contributor

@sadick254 sadick254 commented Oct 22, 2020

Thats correct @gopipofficial

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 23, 2020

Thanks, I'm starting with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.