Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed ReloadBaseTypes being called 2 times when entering play mode #832
Conversation
Fixes an issue with MultiScaleVO showing incorrectly if XR and single pass stereo is enabled for a project, but the current camera not actually doing stereo rendering, like the scene view or when the HMD isn't active, or for "social" camera views.
…mode. The same thing occurs with EditorUtilities.ReloadDecoratorTypes, but the fix cannot be applied in this context.
added 19 commits
Sep 6, 2019
…g/tree/patch-1' into v2 # Conflicts: # PostProcessing/Runtime/Effects/MultiScaleVO.cs
… issue fix from manutoo
# Conflicts: # PostProcessing/Shaders/Builtins/ScreenSpaceReflections.hlsl Added .gitattributes from ypapouin@cc0a269 Added pull request #854
…x' into v2
Added temp fix : https://github.com/Unity-Technologies/PostProcessing/issues/826
Updated package.json
==> NOTE: Adding all changes by this commit will break the enable/disable behavior on the PostProcessVolume (need investigations) Added changes from Tspk91@d3a2830
Revert package relative path of includes in shaders (to keep the good old .package approach working)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PierreGac commentedJul 8, 2019
It appears that when entering in playmode, the
ReloadBaseTypes()is called 2 times:instance.ReloadBaseTypes()=> when the instance is null a new one will be created. Inside the ctor, at the end,ReloadBaseTypes()is called first. Then called again by the returned instance (instance.ReloadBaseTypes().This fix will avoid such thing to happen.
The same issue occurs with EditorUtilities.ReloadDecoratorTypes but the previous fix cannot be applied (execution order is unclear)