Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove wording of browser notifications #5211
Comments
|
@evabeylin good idea! The original tx notification was done by a community member and we were just stoked to have something better than the status quo! It'd be nice to show (1) the name of the contract the user is interacting with and (2) the type of interaction ("sent ether", "approve", etc). It's possible we know neither (i.e. "unknown function"), in which case we should could fallback to the nonce. @danfinlay thoughts? |
|
This design space can be pretty wide open for us. Our I like the idea of incorporating the source site. I also wouldn't mind including a method-name comprehension, maybe using eth-method-registry. |
|
It strikes me that this string of text is not using our internationalization. That's bad. Also it probably shouldn't be in the platform definition file, since the wording probably isn't platform-specific. Anyways, just adding notes here. |
|
@danfinlay How many confirmations does MetaMask wait for to show this chrome extension? EDIT: for anyone interested in this, it's one confirmation. This should probably be configurable. |
bdresser
changed the title
|
Is this still being prioritized? Honestly having no clarity on what the txn was creates poor UX for those using multiple ethereum dapps. If I'm making multiple transactions on various dapps in the same time period, I have no way of knowing what was confirmed unless I go to etherscan everytime... |
|
@evabeylin yep, we're working on re-vamping the copy used across the extension to describe transactions. thanks for your patience! cc @rachelcope |
Suggested improvement on the chrome pop-up confirming a transaction:
Currently the pop-up states "Transaction #X" is confirmed. With X being the number of the transaction from that user's ethereum address. Even better if instead of the transaction number, other metadata could be used as the description for the transaction confirmation - such as the dapp or browser the transaction was occuring on, the token that was transferred etc.
E.g., instead of Alice conducting a 6th transaction from her Ethereum address to purchase a Cryptokitty and the pop-up stating "Transaction 6 Confirmed" --> "Cryptokitties Transaction Confirmed".
Can enable better UX and ensure that if users are conducting ethereum transactions across multiple platforms in the same time frame, they can know which or where the transaction took place.