The Wayback Machine - https://web.archive.org/web/20201014164141/https://github.com/google/ko/issues/3
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a `ko` image (`gcr.io/$PROJECT_ID/ko`) #3

Open
bobcatfish opened this issue Mar 1, 2019 · 5 comments
Open

Publish a `ko` image (`gcr.io/$PROJECT_ID/ko`) #3

bobcatfish opened this issue Mar 1, 2019 · 5 comments

Comments

@bobcatfish
Copy link

@bobcatfish bobcatfish commented Mar 1, 2019

In tektoncd/pipeline#529 and tektoncd/pipeline#528 I'm adding dogfooding CI/CD logic for publishing tekton pipelines images and yamls.

This means I want to create a Task step or steps which invoke ko, since this is how we currently build and publish our images (via a bash script).

To do this, I need a container with ko installed. For now I'll have a first step that installs ko, but would be great if a ko image could be published and available for folks to use.

(Looks like #358 might be related but I'm not sure?)

@bobcatfish
Copy link
Author

@bobcatfish bobcatfish commented Mar 18, 2019

Additionally can this image also know how to auth with provided kubernetes style service accounts (maybe via mounted files or environment variables)? 🙏

@bobcatfish
Copy link
Author

@bobcatfish bobcatfish commented Mar 18, 2019

After some discussion with @jonjohnsonjr , a couple options for the auth interface:

  1. Compile a different ko binary for use in the image which does something similar to how kaniko detects if its running in k8s and uses k8schain in that case
  2. Create a k8schain-based cred helper that is bundled in the image, e.g. something like https://github.com/docker/docker-credential-helpers <-- the better option!
@jonjohnsonjr
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr commented Mar 18, 2019

Best option, I think, is to mount docker push secrets at ~/.docker/config.json, which ko would then pick up. Similar to https://github.com/tektoncd/pipeline/blob/master/docs/auth.md#basic-authentication-docker

@jonjohnsonjr jonjohnsonjr transferred this issue from google/go-containerregistry Mar 21, 2019
@github-actions
Copy link

@github-actions github-actions bot commented Sep 26, 2020

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@06kellyjac
Copy link

@06kellyjac 06kellyjac commented Sep 26, 2020

I'd still like an official ko image or at least a reason why not to have one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.