Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd re-run last test option #572
Open
Conversation
added 2 commits
Jun 12, 2020
src/commands/test.ts
Outdated
| @@ -42,6 +42,12 @@ export async function testSolution(uri?: vscode.Uri): Promise<void> { | |||
| detail: "Test with the written cases in file", | |||
| value: ":file", | |||
| }, | |||
| { | |||
| label: "$(refresh) Re- run last...", | |||
This comment has been minimized.
This comment has been minimized.
jdneo
Jun 27, 2020
Member
UI: Use this icon please: $(debug-restart)
reference: https://microsoft.github.io/vscode-codicons/dist/codicon.html
|
Hey @nathanesau, Thank you for your contribution, and sorry for the late reply... I think it could be better if we use the icon |
|
@nathanesau, will you still have the interest to update the PR? |
and others
added 2 commits
Jul 23, 2020
|
Sorry for the delay. I have made the change (commit "use debug-start icon"):
|
| @@ -42,6 +42,12 @@ export async function testSolution(uri?: vscode.Uri): Promise<void> { | |||
| detail: "Test with the written cases in file", | |||
| value: ":file", | |||
| }, | |||
| { | |||
| label: "$(debug-restart) Re-run last...", | |||
This comment has been minimized.
This comment has been minimized.
jdneo
Jul 24, 2020
Member
One suggestion here: We should only show the re-run option when the lastTest is not empty. Also, this option should put at the top of the list, to make it more convenient for the users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nathanesau commentedJun 12, 2020
Implement request from Issue #570